Evgenii Stratonikov
91c8a1a1fc
Current flow is hard to reason about, #1601 is a notorious example of accidental complexity. 1. Remove multiple nested ifs, use depth=1. 2. Process each status exactly once, hopefully preventing bugs like #1601. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
42 lines
1 KiB
Go
42 lines
1 KiB
Go
package policer
|
|
|
|
import "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/netmap"
|
|
|
|
type nodeProcessStatus int8
|
|
|
|
const (
|
|
nodeNotProcessed nodeProcessStatus = iota
|
|
nodeDoesNotHoldObject
|
|
nodeHoldsObject
|
|
nodeStatusUnknown
|
|
nodeIsUnderMaintenance
|
|
nodeIsLocal
|
|
)
|
|
|
|
func (st nodeProcessStatus) Processed() bool {
|
|
return st != nodeNotProcessed
|
|
}
|
|
|
|
// nodeCache tracks Policer's check progress.
|
|
type nodeCache map[uint64]nodeProcessStatus
|
|
|
|
func newNodeCache() nodeCache {
|
|
return make(map[uint64]nodeProcessStatus)
|
|
}
|
|
|
|
func (n nodeCache) set(node netmap.NodeInfo, val nodeProcessStatus) {
|
|
n[node.Hash()] = val
|
|
}
|
|
|
|
// processStatus returns current processing status of the storage node.
|
|
func (n nodeCache) processStatus(node netmap.NodeInfo) nodeProcessStatus {
|
|
return n[node.Hash()]
|
|
}
|
|
|
|
// SubmitSuccessfulReplication marks given storage node as a current object
|
|
// replica holder.
|
|
//
|
|
// SubmitSuccessfulReplication implements replicator.TaskResult.
|
|
func (n nodeCache) SubmitSuccessfulReplication(node netmap.NodeInfo) {
|
|
n.set(node, nodeHoldsObject)
|
|
}
|