Aleksey Savchuk
4919b6a206
All checks were successful
Vulncheck / Vulncheck (push) Successful in 1m14s
Pre-commit hooks / Pre-commit (push) Successful in 1m51s
Build / Build Components (push) Successful in 2m1s
Tests and linters / Run gofumpt (push) Successful in 2m38s
Tests and linters / Tests (push) Successful in 2m53s
Tests and linters / Staticcheck (push) Successful in 3m9s
Tests and linters / Lint (push) Successful in 4m5s
Tests and linters / gopls check (push) Successful in 4m34s
OCI image / Build container images (push) Successful in 4m58s
Tests and linters / Tests with -race (push) Successful in 5m59s
The limiter allows zeros for limits, meaning "this operation is disabled". However, the config didn't allow zero due to the lack of distinction between "no value" and "zero" - cast functions read both `nil` and zero as zero. Now, the config allows a zero limit. Added tests. Managing such cases should be easier after #1610. Change-Id: Ifc840732390b2feb975f230573b34bf479406e05 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
77 lines
2.1 KiB
Go
77 lines
2.1 KiB
Go
package rpcconfig
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/config"
|
|
configtest "git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/config/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRPCSection(t *testing.T) {
|
|
t.Run("defaults", func(t *testing.T) {
|
|
require.Empty(t, Limits(configtest.EmptyConfig()))
|
|
})
|
|
|
|
t.Run("correct config", func(t *testing.T) {
|
|
const path = "../../../../config/example/node"
|
|
|
|
fileConfigTest := func(c *config.Config) {
|
|
limits := Limits(c)
|
|
require.Len(t, limits, 2)
|
|
|
|
limit0 := limits[0]
|
|
limit1 := limits[1]
|
|
|
|
require.ElementsMatch(t, limit0.Methods, []string{"/neo.fs.v2.object.ObjectService/PutSingle", "/neo.fs.v2.object.ObjectService/Put"})
|
|
require.Equal(t, limit0.MaxOps, int64(1000))
|
|
|
|
require.ElementsMatch(t, limit1.Methods, []string{"/neo.fs.v2.object.ObjectService/Get"})
|
|
require.Equal(t, limit1.MaxOps, int64(10000))
|
|
}
|
|
|
|
configtest.ForEachFileType(path, fileConfigTest)
|
|
|
|
t.Run("ENV", func(t *testing.T) {
|
|
configtest.ForEnvFileType(t, path, fileConfigTest)
|
|
})
|
|
})
|
|
|
|
t.Run("no max operations", func(t *testing.T) {
|
|
const path = "testdata/no_max_ops"
|
|
|
|
fileConfigTest := func(c *config.Config) {
|
|
require.Panics(t, func() { _ = Limits(c) })
|
|
}
|
|
|
|
configtest.ForEachFileType(path, fileConfigTest)
|
|
|
|
t.Run("ENV", func(t *testing.T) {
|
|
configtest.ForEnvFileType(t, path, fileConfigTest)
|
|
})
|
|
})
|
|
|
|
t.Run("zero max operations", func(t *testing.T) {
|
|
const path = "testdata/zero_max_ops"
|
|
|
|
fileConfigTest := func(c *config.Config) {
|
|
limits := Limits(c)
|
|
require.Len(t, limits, 2)
|
|
|
|
limit0 := limits[0]
|
|
limit1 := limits[1]
|
|
|
|
require.ElementsMatch(t, limit0.Methods, []string{"/neo.fs.v2.object.ObjectService/PutSingle", "/neo.fs.v2.object.ObjectService/Put"})
|
|
require.Equal(t, limit0.MaxOps, int64(0))
|
|
|
|
require.ElementsMatch(t, limit1.Methods, []string{"/neo.fs.v2.object.ObjectService/Get"})
|
|
require.Equal(t, limit1.MaxOps, int64(10000))
|
|
}
|
|
|
|
configtest.ForEachFileType(path, fileConfigTest)
|
|
|
|
t.Run("ENV", func(t *testing.T) {
|
|
configtest.ForEnvFileType(t, path, fileConfigTest)
|
|
})
|
|
})
|
|
}
|