Evgenii Stratonikov
15102e6dfd
`slices.SortFunc` doesn't use reflection and is a bit faster.
I have done some micro-benchmarks for `[]NodeInfo`:
```
$ benchstat -col "/func" out
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/pilorama
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
│ sort.Slice │ slices.SortFunc │
│ sec/op │ sec/op vs base │
Sort-8 2.130µ ± 2% 1.253µ ± 2% -41.20% (p=0.000 n=10)
```
Haven't included them, though, as they I don't see them being used a
lot.
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
58 lines
1.6 KiB
Go
58 lines
1.6 KiB
Go
package common
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
"strings"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
|
|
commonCmd "git.frostfs.info/TrueCloudLab/frostfs-node/cmd/internal/common"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/misc"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-observability/tracing"
|
|
"github.com/spf13/cobra"
|
|
"go.opentelemetry.io/otel/trace"
|
|
)
|
|
|
|
type spanKey struct{}
|
|
|
|
// StopClientCommandSpan stops tracing span for the command and prints trace ID on the standard output.
|
|
func StopClientCommandSpan(cmd *cobra.Command, _ []string) {
|
|
span, ok := cmd.Context().Value(spanKey{}).(trace.Span)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
span.End()
|
|
|
|
// Noop provider cannot fail on flush.
|
|
_ = tracing.Shutdown(cmd.Context())
|
|
|
|
cmd.PrintErrf("Trace ID: %s\n", span.SpanContext().TraceID())
|
|
}
|
|
|
|
// StartClientCommandSpan starts tracing span for the command.
|
|
func StartClientCommandSpan(cmd *cobra.Command) {
|
|
enableTracing, err := cmd.Flags().GetBool(commonflags.TracingFlag)
|
|
if err != nil || !enableTracing {
|
|
return
|
|
}
|
|
|
|
_, err = tracing.Setup(cmd.Context(), tracing.Config{
|
|
Enabled: true,
|
|
Exporter: tracing.NoOpExporter,
|
|
Service: "frostfs-cli",
|
|
Version: misc.Version,
|
|
})
|
|
commonCmd.ExitOnErr(cmd, "init tracing: %w", err)
|
|
|
|
var components []string
|
|
for c := cmd; c != nil; c = c.Parent() {
|
|
components = append(components, c.Name())
|
|
}
|
|
slices.Reverse(components)
|
|
|
|
operation := strings.Join(components, ".")
|
|
ctx, span := tracing.StartSpanFromContext(cmd.Context(), operation)
|
|
ctx = context.WithValue(ctx, spanKey{}, span)
|
|
cmd.SetContext(ctx)
|
|
}
|