Dmitrii Stepanov
8a57c78f5f
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m38s
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m51s
DCO action / DCO (pull_request) Successful in 2m53s
Vulncheck / Vulncheck (pull_request) Successful in 3m44s
Tests and linters / gopls check (pull_request) Successful in 3m53s
Build / Build Components (pull_request) Successful in 4m15s
Tests and linters / Staticcheck (pull_request) Successful in 4m56s
Tests and linters / Tests with -race (pull_request) Successful in 5m5s
Tests and linters / Lint (pull_request) Successful in 5m47s
Tests and linters / Tests (pull_request) Successful in 5m51s
1. Add forgotten metrics for client requests 2. Include execIfNotBlocked into metrics Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
139 lines
4.4 KiB
Go
139 lines
4.4 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/util/logicerr"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-observability/tracing"
|
|
apistatus "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client/status"
|
|
cid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
|
|
objectSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object"
|
|
oid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/id"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
var errLockFailed = errors.New("lock operation failed")
|
|
|
|
// Lock marks objects as locked with another object. All objects from the
|
|
// specified container.
|
|
//
|
|
// Allows locking regular objects only (otherwise returns apistatus.LockNonRegularObject).
|
|
//
|
|
// Locked list should be unique. Panics if it is empty.
|
|
func (e *StorageEngine) Lock(ctx context.Context, idCnr cid.ID, locker oid.ID, locked []oid.ID) error {
|
|
ctx, span := tracing.StartSpanFromContext(ctx, "StorageEngine.Lock",
|
|
trace.WithAttributes(
|
|
attribute.String("container_id", idCnr.EncodeToString()),
|
|
attribute.String("locker", locker.EncodeToString()),
|
|
attribute.Int("locked_count", len(locked)),
|
|
))
|
|
defer span.End()
|
|
defer elapsed("Lock", e.metrics.AddMethodDuration)()
|
|
|
|
return e.execIfNotBlocked(func() error {
|
|
return e.lock(ctx, idCnr, locker, locked)
|
|
})
|
|
}
|
|
|
|
func (e *StorageEngine) lock(ctx context.Context, idCnr cid.ID, locker oid.ID, locked []oid.ID) error {
|
|
for i := range locked {
|
|
switch e.lockSingle(ctx, idCnr, locker, locked[i], true) {
|
|
case 1:
|
|
return logicerr.Wrap(new(apistatus.LockNonRegularObject))
|
|
case 0:
|
|
switch e.lockSingle(ctx, idCnr, locker, locked[i], false) {
|
|
case 1:
|
|
return logicerr.Wrap(new(apistatus.LockNonRegularObject))
|
|
case 0:
|
|
return logicerr.Wrap(errLockFailed)
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Returns:
|
|
// - 0: fail
|
|
// - 1: locking irregular object
|
|
// - 2: ok
|
|
func (e *StorageEngine) lockSingle(ctx context.Context, idCnr cid.ID, locker, locked oid.ID, checkExists bool) (status uint8) {
|
|
// code is pretty similar to inhumeAddr, maybe unify?
|
|
root := false
|
|
var addrLocked oid.Address
|
|
addrLocked.SetContainer(idCnr)
|
|
addrLocked.SetObject(locked)
|
|
e.iterateOverSortedShards(addrLocked, func(_ int, sh hashedShard) (stop bool) {
|
|
defer func() {
|
|
// if object is root we continue since information about it
|
|
// can be presented in other shards
|
|
if checkExists && root {
|
|
stop = false
|
|
}
|
|
}()
|
|
|
|
if checkExists {
|
|
var existsPrm shard.ExistsPrm
|
|
existsPrm.Address = addrLocked
|
|
exRes, err := sh.Exists(ctx, existsPrm)
|
|
if err != nil {
|
|
var siErr *objectSDK.SplitInfoError
|
|
var eiErr *objectSDK.ECInfoError
|
|
if errors.As(err, &eiErr) {
|
|
eclocked := []oid.ID{locked}
|
|
for _, chunk := range eiErr.ECInfo().Chunks {
|
|
var objID oid.ID
|
|
err = objID.ReadFromV2(chunk.ID)
|
|
if err != nil {
|
|
e.reportShardError(sh, "could not lock object in shard", err, zap.Stringer("container_id", idCnr),
|
|
zap.Stringer("locker_id", locker), zap.Stringer("locked_id", locked))
|
|
return false
|
|
}
|
|
eclocked = append(eclocked, objID)
|
|
}
|
|
err = sh.Lock(ctx, idCnr, locker, eclocked)
|
|
if err != nil {
|
|
e.reportShardError(sh, "could not lock object in shard", err, zap.Stringer("container_id", idCnr),
|
|
zap.Stringer("locker_id", locker), zap.Stringer("locked_id", locked))
|
|
return false
|
|
}
|
|
root = true
|
|
return false
|
|
} else if !errors.As(err, &siErr) {
|
|
if shard.IsErrObjectExpired(err) {
|
|
// object is already expired =>
|
|
// do not lock it
|
|
return true
|
|
}
|
|
e.reportShardError(sh, "could not check locked object for presence in shard", err, zap.Stringer("container_id", idCnr),
|
|
zap.Stringer("locker_id", locker), zap.Stringer("locked_id", locked))
|
|
return
|
|
}
|
|
|
|
root = true
|
|
} else if !exRes.Exists() {
|
|
return
|
|
}
|
|
}
|
|
|
|
err := sh.Lock(ctx, idCnr, locker, []oid.ID{locked})
|
|
if err != nil {
|
|
e.reportShardError(sh, "could not lock object in shard", err, zap.Stringer("container_id", idCnr),
|
|
zap.Stringer("locker_id", locker), zap.Stringer("locked_id", locked))
|
|
|
|
var errIrregular *apistatus.LockNonRegularObject
|
|
if errors.As(err, &errIrregular) {
|
|
status = 1
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
status = 2
|
|
return true
|
|
})
|
|
return
|
|
}
|