abfcc7498c
In previous implementation of Policer's job queue the same list of objects for processing was selected at each iteration. This was caused by consistent return of `engine.List` function. Use `rand.Shuffle` function to compose pseudo-random list of all objects in order to approximately evenly distribute objects to work. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
32 lines
776 B
Go
32 lines
776 B
Go
package policer
|
|
|
|
import (
|
|
"github.com/nspcc-dev/neofs-api-go/pkg/object"
|
|
"github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine"
|
|
"github.com/nspcc-dev/neofs-node/pkg/util/rand"
|
|
)
|
|
|
|
type jobQueue struct {
|
|
localStorage *engine.StorageEngine
|
|
}
|
|
|
|
func (q *jobQueue) Select(limit int) ([]*object.Address, error) {
|
|
// TODO: optimize the logic for selecting objects
|
|
// We can prioritize objects for migration, newly arrived objects, etc.
|
|
// It is recommended to make changes after updating the metabase
|
|
|
|
res, err := engine.List(q.localStorage, 0) // consider some limit
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
rand.New().Shuffle(len(res), func(i, j int) {
|
|
res[i], res[j] = res[j], res[i]
|
|
})
|
|
|
|
if len(res) < limit {
|
|
return res, nil
|
|
}
|
|
|
|
return res[:limit], nil
|
|
}
|