Dmitrii Stepanov
f2437f7ae9
All checks were successful
DCO action / DCO (pull_request) Successful in 1m36s
Build / Build Components (1.20) (pull_request) Successful in 3m46s
Vulncheck / Vulncheck (pull_request) Successful in 3m16s
Tests and linters / Staticcheck (pull_request) Successful in 4m42s
Tests and linters / Tests (1.20) (pull_request) Successful in 6m27s
Tests and linters / Tests (1.21) (pull_request) Successful in 6m35s
Tests and linters / Tests with -race (pull_request) Successful in 6m33s
Build / Build Components (1.21) (pull_request) Successful in 13m7s
Tests and linters / Lint (pull_request) Successful in 19m14s
Due to the flushing data from the writecache to the storage and simultaneous deletion, a partial deletion situation is possible. So as a solution, deletion is allowed only when the object is in storage, because object will be deleted from writecache by flush goroutine. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
99 lines
2.4 KiB
Go
99 lines
2.4 KiB
Go
package shard
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/core/object"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/internal/testutil"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client"
|
|
cidtest "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestShard_Delete(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("without write cache", func(t *testing.T) {
|
|
t.Parallel()
|
|
testShardDelete(t, false)
|
|
})
|
|
|
|
t.Run("with write cache", func(t *testing.T) {
|
|
t.Parallel()
|
|
testShardDelete(t, true)
|
|
})
|
|
}
|
|
|
|
func testShardDelete(t *testing.T, hasWriteCache bool) {
|
|
sh := newShard(t, hasWriteCache)
|
|
|
|
cnr := cidtest.ID()
|
|
|
|
obj := testutil.GenerateObjectWithCID(cnr)
|
|
testutil.AddAttribute(obj, "foo", "bar")
|
|
|
|
var putPrm PutPrm
|
|
var getPrm GetPrm
|
|
|
|
t.Run("big object", func(t *testing.T) {
|
|
testutil.AddPayload(obj, 1<<20)
|
|
|
|
putPrm.SetObject(obj)
|
|
getPrm.SetAddress(object.AddressOf(obj))
|
|
|
|
var delPrm DeletePrm
|
|
delPrm.SetAddresses(object.AddressOf(obj))
|
|
|
|
_, err := sh.Put(context.Background(), putPrm)
|
|
require.NoError(t, err)
|
|
|
|
_, err = testGet(t, sh, getPrm, hasWriteCache)
|
|
require.NoError(t, err)
|
|
|
|
if hasWriteCache {
|
|
require.Eventually(t, func() bool {
|
|
_, err = sh.Delete(context.Background(), delPrm)
|
|
return err == nil
|
|
}, 30*time.Second, 100*time.Millisecond)
|
|
} else {
|
|
_, err = sh.Delete(context.Background(), delPrm)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
_, err = sh.Get(context.Background(), getPrm)
|
|
require.True(t, client.IsErrObjectNotFound(err))
|
|
})
|
|
|
|
t.Run("small object", func(t *testing.T) {
|
|
obj := testutil.GenerateObjectWithCID(cnr)
|
|
testutil.AddAttribute(obj, "foo", "bar")
|
|
testutil.AddPayload(obj, 1<<5)
|
|
|
|
putPrm.SetObject(obj)
|
|
getPrm.SetAddress(object.AddressOf(obj))
|
|
|
|
var delPrm DeletePrm
|
|
delPrm.SetAddresses(object.AddressOf(obj))
|
|
|
|
_, err := sh.Put(context.Background(), putPrm)
|
|
require.NoError(t, err)
|
|
|
|
_, err = sh.Get(context.Background(), getPrm)
|
|
require.NoError(t, err)
|
|
|
|
if hasWriteCache {
|
|
require.Eventually(t, func() bool {
|
|
_, err = sh.Delete(context.Background(), delPrm)
|
|
return err == nil
|
|
}, 10*time.Second, 100*time.Millisecond)
|
|
} else {
|
|
_, err = sh.Delete(context.Background(), delPrm)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
_, err = sh.Get(context.Background(), getPrm)
|
|
require.True(t, client.IsErrObjectNotFound(err))
|
|
})
|
|
}
|