97b6ec8150
Make `StorageEngine.Inhume` to forward first encountered `apistatus.ObjectLocked` error during shard processing. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
174 lines
4 KiB
Go
174 lines
4 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/nspcc-dev/neofs-node/pkg/core/object"
|
|
"github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard"
|
|
apistatus "github.com/nspcc-dev/neofs-sdk-go/client/status"
|
|
objectSDK "github.com/nspcc-dev/neofs-sdk-go/object"
|
|
addressSDK "github.com/nspcc-dev/neofs-sdk-go/object/address"
|
|
)
|
|
|
|
// InhumePrm encapsulates parameters for inhume operation.
|
|
type InhumePrm struct {
|
|
tombstone *addressSDK.Address
|
|
addrs []*addressSDK.Address
|
|
}
|
|
|
|
// InhumeRes encapsulates results of inhume operation.
|
|
type InhumeRes struct{}
|
|
|
|
// WithTarget sets list of objects that should be inhumed and tombstone address
|
|
// as the reason for inhume operation.
|
|
//
|
|
// tombstone should not be nil, addr should not be empty.
|
|
// Should not be called along with MarkAsGarbage.
|
|
func (p *InhumePrm) WithTarget(tombstone *addressSDK.Address, addrs ...*addressSDK.Address) *InhumePrm {
|
|
if p != nil {
|
|
p.addrs = addrs
|
|
p.tombstone = tombstone
|
|
}
|
|
|
|
return p
|
|
}
|
|
|
|
// MarkAsGarbage marks object to be physically removed from local storage.
|
|
//
|
|
// Should not be called along with WithTarget.
|
|
func (p *InhumePrm) MarkAsGarbage(addrs ...*addressSDK.Address) *InhumePrm {
|
|
if p != nil {
|
|
p.addrs = addrs
|
|
p.tombstone = nil
|
|
}
|
|
|
|
return p
|
|
}
|
|
|
|
var errInhumeFailure = errors.New("inhume operation failed")
|
|
|
|
// Inhume calls metabase. Inhume method to mark object as removed. It won't be
|
|
// removed physically from shard until `Delete` operation.
|
|
//
|
|
// Allows inhuming non-locked objects only. Returns apistatus.ObjectLocked
|
|
// if at least one object is locked.
|
|
//
|
|
// Returns an error if executions are blocked (see BlockExecution).
|
|
func (e *StorageEngine) Inhume(prm *InhumePrm) (res *InhumeRes, err error) {
|
|
err = e.execIfNotBlocked(func() error {
|
|
res, err = e.inhume(prm)
|
|
return err
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
func (e *StorageEngine) inhume(prm *InhumePrm) (*InhumeRes, error) {
|
|
if e.metrics != nil {
|
|
defer elapsed(e.metrics.AddInhumeDuration)()
|
|
}
|
|
|
|
shPrm := new(shard.InhumePrm)
|
|
|
|
for i := range prm.addrs {
|
|
if prm.tombstone != nil {
|
|
shPrm.WithTarget(prm.tombstone, prm.addrs[i])
|
|
} else {
|
|
shPrm.MarkAsGarbage(prm.addrs[i])
|
|
}
|
|
|
|
switch e.inhumeAddr(prm.addrs[i], shPrm, true) {
|
|
case 1:
|
|
return nil, apistatus.ObjectLocked{}
|
|
case 0:
|
|
switch e.inhumeAddr(prm.addrs[i], shPrm, false) {
|
|
case 1:
|
|
return nil, apistatus.ObjectLocked{}
|
|
case 0:
|
|
return nil, errInhumeFailure
|
|
}
|
|
}
|
|
}
|
|
|
|
return new(InhumeRes), nil
|
|
}
|
|
|
|
// Returns:
|
|
// 0 - fail
|
|
// 1 - object locked
|
|
// 2 - ok
|
|
func (e *StorageEngine) inhumeAddr(addr *addressSDK.Address, prm *shard.InhumePrm, checkExists bool) (status uint8) {
|
|
root := false
|
|
var errLocked apistatus.ObjectLocked
|
|
|
|
e.iterateOverSortedShards(addr, func(_ int, sh hashedShard) (stop bool) {
|
|
defer func() {
|
|
// if object is root we continue since information about it
|
|
// can be presented in other shards
|
|
if checkExists && root {
|
|
stop = false
|
|
}
|
|
}()
|
|
|
|
if checkExists {
|
|
exRes, err := sh.Exists(new(shard.ExistsPrm).
|
|
WithAddress(addr),
|
|
)
|
|
if err != nil {
|
|
if errors.Is(err, object.ErrAlreadyRemoved) {
|
|
// inhumed once - no need to be inhumed again
|
|
status = 2
|
|
return true
|
|
}
|
|
|
|
var siErr *objectSDK.SplitInfoError
|
|
if !errors.As(err, &siErr) {
|
|
e.reportShardError(sh, "could not check for presents in shard", err)
|
|
return
|
|
}
|
|
|
|
root = true
|
|
} else if !exRes.Exists() {
|
|
return
|
|
}
|
|
}
|
|
|
|
_, err := sh.Inhume(prm)
|
|
if err != nil {
|
|
e.reportShardError(sh, "could not inhume object in shard", err)
|
|
|
|
if errors.As(err, &errLocked) {
|
|
status = 1
|
|
return true
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
status = 2
|
|
|
|
return true
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
func (e *StorageEngine) processExpiredTombstones(ctx context.Context, addrs []*addressSDK.Address) {
|
|
tss := make(map[string]*addressSDK.Address, len(addrs))
|
|
|
|
for i := range addrs {
|
|
tss[addrs[i].String()] = addrs[i]
|
|
}
|
|
|
|
e.iterateOverUnsortedShards(func(sh hashedShard) (stop bool) {
|
|
sh.HandleExpiredTombstones(tss)
|
|
|
|
select {
|
|
case <-ctx.Done():
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
})
|
|
}
|