e48f8a189e
The previous metabase implementation took an exclusionary approach: filters narrowed the set of all objects to those that match all filters. An inclusive approach is presented. In it, when traversing the indexed headers, the object becomes a candidate for selection. If at least one of the subsequent filters is not passed, the object ceases to be a candidate. At the end of the traversal, the remaining candidates are added to the resulting sample. The borderline case of no filters is handled in a special way: all stored objects are added to the resulting selection. Presented inclusive approach showed better performance in most scenarios (although not all). Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
105 lines
2.3 KiB
Go
105 lines
2.3 KiB
Go
package meta
|
|
|
|
import (
|
|
"github.com/nspcc-dev/neofs-api-go/pkg/object"
|
|
"github.com/pkg/errors"
|
|
"go.etcd.io/bbolt"
|
|
)
|
|
|
|
// Select returns list of addresses of objects that match search filters.
|
|
func (db *DB) Select(fs object.SearchFilters) ([]*object.Address, error) {
|
|
res := make([]*object.Address, 0)
|
|
|
|
err := db.boltDB.View(func(tx *bbolt.Tx) error {
|
|
// get indexed bucket
|
|
indexBucket := tx.Bucket(indexBucket)
|
|
if indexBucket == nil {
|
|
// empty storage
|
|
return nil
|
|
}
|
|
|
|
if len(fs) == 0 {
|
|
// get primary bucket
|
|
primaryBucket := tx.Bucket(primaryBucket)
|
|
if primaryBucket == nil {
|
|
// empty storage
|
|
return nil
|
|
}
|
|
|
|
// iterate over all stored addresses
|
|
return primaryBucket.ForEach(func(k, v []byte) error {
|
|
// check if object marked as deleted
|
|
if objectRemoved(tx, k) {
|
|
return nil
|
|
}
|
|
|
|
addr := object.NewAddress()
|
|
if err := addr.Parse(string(k)); err != nil {
|
|
// TODO: storage was broken, so we need to handle it
|
|
return err
|
|
}
|
|
|
|
res = append(res, addr)
|
|
|
|
return nil
|
|
})
|
|
}
|
|
|
|
// keep processed addresses
|
|
mAddr := make(map[string]struct{})
|
|
|
|
for _, f := range fs {
|
|
matchFunc, ok := db.matchers[f.Operation()]
|
|
if !ok {
|
|
return errors.Errorf("no function for matcher %v", f.Operation())
|
|
}
|
|
|
|
key := f.Header()
|
|
|
|
// get bucket with values
|
|
keyBucket := indexBucket.Bucket([]byte(key))
|
|
if keyBucket == nil {
|
|
// no object has this attribute => empty result
|
|
return nil
|
|
}
|
|
|
|
fVal := f.Value()
|
|
|
|
// iterate over all existing values for the key
|
|
if err := keyBucket.ForEach(func(k, _ []byte) error {
|
|
include := matchFunc(string(key), string(cutKeyBytes(k)), fVal)
|
|
|
|
return keyBucket.Bucket(k).ForEach(func(k, _ []byte) error {
|
|
if include {
|
|
mAddr[string(k)] = struct{}{}
|
|
} else {
|
|
delete(mAddr, string(k))
|
|
}
|
|
|
|
return nil
|
|
})
|
|
}); err != nil {
|
|
return errors.Wrapf(err, "(%T) could not iterate bucket %s", db, key)
|
|
}
|
|
}
|
|
|
|
for a := range mAddr {
|
|
// check if object marked as deleted
|
|
if objectRemoved(tx, []byte(a)) {
|
|
return nil
|
|
}
|
|
|
|
addr := object.NewAddress()
|
|
if err := addr.Parse(a); err != nil {
|
|
// TODO: storage was broken, so we need to handle it
|
|
return err
|
|
}
|
|
|
|
res = append(res, addr)
|
|
}
|
|
|
|
return nil
|
|
})
|
|
|
|
return res, err
|
|
}
|