All checks were successful
DCO action / DCO (pull_request) Successful in 49s
Vulncheck / Vulncheck (pull_request) Successful in 1m7s
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m32s
Build / Build Components (pull_request) Successful in 1m48s
Tests and linters / Run gofumpt (pull_request) Successful in 3m29s
Tests and linters / Lint (pull_request) Successful in 4m1s
Tests and linters / Staticcheck (pull_request) Successful in 4m5s
Tests and linters / Tests (pull_request) Successful in 4m49s
Tests and linters / Tests with -race (pull_request) Successful in 5m30s
Tests and linters / gopls check (pull_request) Successful in 5m42s
There are some buckets we access almost always, to check whether an object is alive. In search we also iterate over lots of objects, and `tx.Bucket()` shows itself a lot in pprof. ``` goos: linux goarch: amd64 pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/metabase cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz │ 1 │ 2 │ │ sec/op │ sec/op vs base │ Select/string_equal-8 4.753m ± 6% 3.969m ± 14% -16.50% (p=0.000 n=10) Select/string_not_equal-8 4.247m ± 9% 3.486m ± 11% -17.93% (p=0.000 n=10) Select/common_prefix-8 4.163m ± 5% 3.323m ± 5% -20.18% (p=0.000 n=10) Select/unknown-8 3.557m ± 3% 3.064m ± 8% -13.85% (p=0.001 n=10) geomean 4.158m 3.445m -17.15% │ 1 │ 2 │ │ B/op │ B/op vs base │ Select/string_equal-8 2.250Mi ± 0% 1.907Mi ± 0% -15.24% (p=0.000 n=10) Select/string_not_equal-8 2.250Mi ± 0% 1.907Mi ± 0% -15.24% (p=0.000 n=10) Select/common_prefix-8 2.250Mi ± 0% 1.907Mi ± 0% -15.24% (p=0.000 n=10) Select/unknown-8 2.243Mi ± 0% 1.900Mi ± 0% -15.29% (p=0.000 n=10) geomean 2.248Mi 1.905Mi -15.26% │ 1 │ 2 │ │ allocs/op │ allocs/op vs base │ Select/string_equal-8 56.02k ± 0% 47.03k ± 0% -16.05% (p=0.000 n=10) Select/string_not_equal-8 56.02k ± 0% 47.03k ± 0% -16.05% (p=0.000 n=10) Select/common_prefix-8 56.02k ± 0% 47.03k ± 0% -16.05% (p=0.000 n=10) Select/unknown-8 55.03k ± 0% 46.04k ± 0% -16.34% (p=0.000 n=10) geomean 55.78k 46.78k -16.12% ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
45 lines
920 B
Go
45 lines
920 B
Go
package meta
|
|
|
|
import (
|
|
"go.etcd.io/bbolt"
|
|
)
|
|
|
|
type bucketCache struct {
|
|
locked *bbolt.Bucket
|
|
graveyard *bbolt.Bucket
|
|
garbage *bbolt.Bucket
|
|
}
|
|
|
|
func newBucketCache() *bucketCache {
|
|
return &bucketCache{}
|
|
}
|
|
|
|
func lockedBucket(bc *bucketCache, tx *bbolt.Tx) *bbolt.Bucket {
|
|
if bc == nil {
|
|
return tx.Bucket(bucketNameLocked)
|
|
}
|
|
return getBucket(&bc.locked, tx, bucketNameLocked)
|
|
}
|
|
|
|
func graveyardBucket(bc *bucketCache, tx *bbolt.Tx) *bbolt.Bucket {
|
|
if bc == nil {
|
|
return tx.Bucket(graveyardBucketName)
|
|
}
|
|
return getBucket(&bc.graveyard, tx, graveyardBucketName)
|
|
}
|
|
|
|
func garbageBucket(bc *bucketCache, tx *bbolt.Tx) *bbolt.Bucket {
|
|
if bc == nil {
|
|
return tx.Bucket(garbageBucketName)
|
|
}
|
|
return getBucket(&bc.garbage, tx, garbageBucketName)
|
|
}
|
|
|
|
func getBucket(cache **bbolt.Bucket, tx *bbolt.Tx, name []byte) *bbolt.Bucket {
|
|
if *cache != nil {
|
|
return *cache
|
|
}
|
|
|
|
*cache = tx.Bucket(name)
|
|
return *cache
|
|
}
|