Aleksey Savchuk
f0c43c8d80
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 3m1s
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m29s
Tests and linters / gopls check (pull_request) Successful in 3m50s
Tests and linters / Lint (pull_request) Successful in 4m35s
DCO action / DCO (pull_request) Successful in 5m12s
Tests and linters / Run gofumpt (pull_request) Successful in 5m33s
Build / Build Components (pull_request) Successful in 5m45s
Tests and linters / Tests with -race (pull_request) Successful in 6m37s
Tests and linters / Tests (pull_request) Successful in 7m17s
Tests and linters / Staticcheck (pull_request) Successful in 7m36s
Tests and linters / Run gofumpt (push) Successful in 1m22s
Tests and linters / Staticcheck (push) Successful in 3m19s
Tests and linters / Lint (push) Successful in 4m35s
Vulncheck / Vulncheck (push) Successful in 5m20s
Build / Build Components (push) Successful in 6m16s
Pre-commit hooks / Pre-commit (push) Successful in 6m37s
Tests and linters / Tests (push) Successful in 6m48s
Tests and linters / Tests with -race (push) Successful in 7m15s
Tests and linters / gopls check (push) Successful in 7m27s
Use `zap.Error` instead of `zap.String` for logging errors: change all expressions like `zap.String("error", err.Error())` or `zap.String("err", err.Error())` to `zap.Error(err)`. Leave similar expressions with other messages unchanged, for example, `zap.String("last_error", lastErr.Error())` or `zap.String("reason", ctx.Err().Error())`. This change was made by applying the following patch: ```diff @@ var err expression @@ -zap.String("error", err.Error()) +zap.Error(err) @@ var err expression @@ -zap.String("err", err.Error()) +zap.Error(err) ``` Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
158 lines
4.2 KiB
Go
158 lines
4.2 KiB
Go
package shard
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/common"
|
|
meta "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/metabase"
|
|
tracingPkg "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/tracing"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-observability/tracing"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/client"
|
|
oid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/id"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
// DeletePrm groups the parameters of Delete operation.
|
|
type DeletePrm struct {
|
|
addr []oid.Address
|
|
}
|
|
|
|
// DeleteRes groups the resulting values of Delete operation.
|
|
type DeleteRes struct {
|
|
deleted uint64
|
|
}
|
|
|
|
// SetAddresses is a Delete option to set the addresses of the objects to delete.
|
|
//
|
|
// Option is required.
|
|
func (p *DeletePrm) SetAddresses(addr ...oid.Address) {
|
|
p.addr = append(p.addr, addr...)
|
|
}
|
|
|
|
// Delete removes data from the shard's metaBase and// blobStor.
|
|
func (s *Shard) Delete(ctx context.Context, prm DeletePrm) (DeleteRes, error) {
|
|
ctx, span := tracing.StartSpanFromContext(ctx, "Shard.Delete",
|
|
trace.WithAttributes(
|
|
attribute.String("shard_id", s.ID().String()),
|
|
attribute.Int("addr_count", len(prm.addr)),
|
|
))
|
|
defer span.End()
|
|
|
|
s.m.RLock()
|
|
defer s.m.RUnlock()
|
|
|
|
return s.delete(ctx, prm, false)
|
|
}
|
|
|
|
func (s *Shard) delete(ctx context.Context, prm DeletePrm, skipFailed bool) (DeleteRes, error) {
|
|
if s.info.Mode.ReadOnly() {
|
|
return DeleteRes{}, ErrReadOnlyMode
|
|
} else if s.info.Mode.NoMetabase() {
|
|
return DeleteRes{}, ErrDegradedMode
|
|
}
|
|
|
|
result := DeleteRes{}
|
|
for _, addr := range prm.addr {
|
|
select {
|
|
case <-ctx.Done():
|
|
return result, ctx.Err()
|
|
default:
|
|
}
|
|
|
|
if err := s.validateWritecacheDoesntContainObject(ctx, addr); err != nil {
|
|
if skipFailed {
|
|
continue
|
|
}
|
|
return result, err
|
|
}
|
|
|
|
if err := s.deleteFromBlobstor(ctx, addr); err != nil {
|
|
if skipFailed {
|
|
continue
|
|
}
|
|
return result, err
|
|
}
|
|
|
|
if err := s.deleteFromMetabase(ctx, addr); err != nil {
|
|
if skipFailed {
|
|
continue
|
|
}
|
|
return result, err
|
|
}
|
|
result.deleted++
|
|
}
|
|
|
|
return result, nil
|
|
}
|
|
|
|
func (s *Shard) validateWritecacheDoesntContainObject(ctx context.Context, addr oid.Address) error {
|
|
if !s.hasWriteCache() {
|
|
return nil
|
|
}
|
|
_, err := s.writeCache.Head(ctx, addr)
|
|
if err == nil {
|
|
s.log.Warn(ctx, logs.ObjectRemovalFailureExistsInWritecache, zap.Stringer("object_address", addr))
|
|
return fmt.Errorf("object %s must be flushed from writecache", addr)
|
|
}
|
|
if client.IsErrObjectNotFound(err) {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (s *Shard) deleteFromBlobstor(ctx context.Context, addr oid.Address) error {
|
|
var sPrm meta.StorageIDPrm
|
|
sPrm.SetAddress(addr)
|
|
|
|
res, err := s.metaBase.StorageID(ctx, sPrm)
|
|
if err != nil {
|
|
s.log.Debug(ctx, logs.StorageIDRetrievalFailure,
|
|
zap.Stringer("object", addr),
|
|
zap.Error(err),
|
|
zap.String("trace_id", tracingPkg.GetTraceID(ctx)))
|
|
return err
|
|
}
|
|
storageID := res.StorageID()
|
|
if storageID == nil {
|
|
// if storageID is nil it means:
|
|
// 1. there is no such object
|
|
// 2. object stored by writecache: should not happen, as `validateWritecacheDoesntContainObject` called before `deleteFromBlobstor`
|
|
return nil
|
|
}
|
|
|
|
var delPrm common.DeletePrm
|
|
delPrm.Address = addr
|
|
delPrm.StorageID = storageID
|
|
|
|
_, err = s.blobStor.Delete(ctx, delPrm)
|
|
if err != nil && !client.IsErrObjectNotFound(err) {
|
|
s.log.Debug(ctx, logs.ObjectRemovalFailureBlobStor,
|
|
zap.Stringer("object_address", addr),
|
|
zap.Error(err),
|
|
zap.String("trace_id", tracingPkg.GetTraceID(ctx)))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *Shard) deleteFromMetabase(ctx context.Context, addr oid.Address) error {
|
|
var delPrm meta.DeletePrm
|
|
delPrm.SetAddresses(addr)
|
|
|
|
res, err := s.metaBase.Delete(ctx, delPrm)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
s.decObjectCounterBy(physical, res.PhyCount())
|
|
s.decObjectCounterBy(logical, res.LogicCount())
|
|
s.decObjectCounterBy(user, res.UserCount())
|
|
s.decContainerObjectCounter(res.RemovedByCnrID())
|
|
s.addToContainerSize(addr.Container().EncodeToString(), -int64(res.LogicSize()))
|
|
s.addToPayloadSize(-int64(res.PhySize()))
|
|
|
|
return nil
|
|
}
|