Add tracing modules #2

dstepanov-yadro · 2023-05-26T15:29:26Z

dstepanov-yadro commented

2023-05-26 15:29:26 +00:00

Tracing modules added

dstepanov-yadro requested review from fyrchik 2023-05-26 15:30:01 +00:00

dstepanov-yadro force-pushed feat/tracing from 349b19c7f6 to 2ebbab8ea7

2023-05-29 06:55:15 +00:00

Compare

dstepanov-yadro changed title from ~~Add tracing configuration~~ to Add tracing modules

2023-05-29 07:11:01 +00:00

dstepanov-yadro force-pushed feat/tracing from 97cfa0d44c to 264ca38592

2023-05-29 08:03:25 +00:00

Compare

dstepanov-yadro force-pushed feat/tracing from 264ca38592 to 53f930dfe7

2023-05-29 08:04:05 +00:00

Compare

dstepanov-yadro force-pushed feat/tracing from 53f930dfe7 to 5f2d1e9bd4

2023-05-29 08:10:10 +00:00

Compare

aarifullin reviewed 2023-05-29 08:22:12 +00:00

tracing/propagator.go Outdated

					
				@ -0,0 +37,4 @@

					var flags int

					if sc.IsSampled() {

						flags = flags | flagsSampled

aarifullin commented

2023-05-29 08:22:12 +00:00

Optionally ;)

flags |= flagsSampled

Optionally ;) ``` flags |= flagsSampled ```

dstepanov-yadro commented

2023-05-29 09:00:53 +00:00

done

aarifullin reviewed 2023-05-29 08:26:23 +00:00

tracing/propagator.go Outdated

					
				@ -0,0 +52,4 @@

					var err error

					traceIDStr := carrier.Get(traceIDHeader)

					traceIDDefined := false

aarifullin commented

2023-05-29 08:26:23 +00:00

Optionally

var traceIDDefined bool
if traceIDDefined = traceIDStr != ""; traceIDDefined {
   /**/
}

or

traceIDDefined := traceIDStr != ""
if traceIDDefined { /**/ }

Optionally ``` var traceIDDefined bool if traceIDDefined = traceIDStr != ""; traceIDDefined { /**/ } ``` or ``` traceIDDefined := traceIDStr != "" if traceIDDefined { /**/ } ```

dstepanov-yadro commented

2023-05-29 09:00:58 +00:00

done

aarifullin approved these changes 2023-05-29 08:48:37 +00:00

dstepanov-yadro force-pushed feat/tracing from f808cc3ed8 to e3fbc9c378

2023-05-29 09:00:42 +00:00

Compare

dstepanov-yadro force-pushed feat/tracing from e3fbc9c378 to f326c3ebbe

2023-05-29 09:14:08 +00:00

Compare

dstepanov-yadro closed this pull request

2023-05-30 09:23:23 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-observability#2