TrueCloudLab/frostfs-observability
22
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add tracing and metrics #3

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-observability:feat/tracing into master 2023-07-26 21:08:06 +00:00
Conversation 0 Commits 1 Files changed 2 +59
dstepanov-yadro commented 2023-05-30 09:32:47 +00:00
Member
Copy link

subj

subj
dstepanov-yadro changed title from tracing: Move from api-go to Add tracing and metrics 2023-05-30 09:47:44 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-05-30 09:48:04 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-05-30 09:48:04 +00:00
acid-ant approved these changes 2023-05-31 06:44:52 +00:00
alexvanin approved these changes 2023-05-31 07:17:01 +00:00
tracing/examples/grpc/main.go Outdated
@ -0,0 +9,4 @@
"time"
srv "git.frostfs.info/TrueCloudLab/frostfs-observability/tracing/examples/grpc/server"
alexvanin commented 2023-05-31 07:14:35 +00:00
Owner
Copy link

Seems like redundant empty line in.

Seems like redundant empty line in.
dstepanov-yadro commented 2023-05-31 07:26:35 +00:00
Author
Member
Copy link

fixed

fixed
dstepanov-yadro force-pushed feat/tracing from 0acec62186 to c3b0f93693 2023-05-31 07:26:34 +00:00 Compare
dstepanov-yadro force-pushed feat/tracing from c3b0f93693 to bbc3e5e556 2023-05-31 08:23:28 +00:00 Compare
dstepanov-yadro force-pushed feat/tracing from bbc3e5e556 to c97d21411e 2023-05-31 08:27:50 +00:00 Compare
dstepanov-yadro reviewed 2023-05-31 08:28:44 +00:00
tracing/grpc/interceptors.go
@ -0,0 +36,4 @@
}
// NewStreamClientInterceptor creates new gRPC stream interceptor to save gRPC client traces.
func NewStreamClientInterceptor() grpc.StreamClientInterceptor {
dstepanov-yadro commented 2023-05-31 08:28:44 +00:00
Author
Member
Copy link

Renamed NewGRPCStreamClientInterceptor -> NewStreamClientInterceptor. Also other interceptors.

Renamed NewGRPCStreamClientInterceptor -> NewStreamClientInterceptor. Also other interceptors.
dstepanov-yadro reviewed 2023-05-31 08:29:51 +00:00
tracing/config.go
@ -0,0 +8,4 @@
const (
StdoutExporter Exporter = "stdout"
OTLPgRPCExporter Exporter = "otlp_grpc"
NoOpExporter Exporter = "noop"
dstepanov-yadro commented 2023-05-31 08:29:51 +00:00
Author
Member
Copy link

Added new exporter for cli: it creates span, but doesn't export it.

Added new exporter for cli: it creates span, but doesn't export it.
👍 1
fyrchik approved these changes 2023-05-31 10:07:37 +00:00
fyrchik merged commit c97d21411e into master 2023-05-31 10:08:15 +00:00
fyrchik referenced this pull request from a commit 2023-05-31 10:08:16 +00:00
[#3] tracing: Move from api-go
fyrchik referenced this pull request from a commit 2023-05-31 10:08:16 +00:00
[#3] metrics: Move from node
fyrchik referenced this pull request from a commit 2023-05-31 10:08:16 +00:00
[#3] metrics: Add gRPC middleware
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
alexvanin
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-observability#3
No description provided.
Delete branch "dstepanov-yadro/frostfs-observability:feat/tracing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?