TrueCloudLab/frostfs-qos
14
0
Fork 6
Code Issues 1 Pull requests Projects Releases Packages Activity Actions

Schedule requests as soon as possible #13

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-qos:fix/limit_scheduling into master 2025-03-28 10:06:02 +00:00
Conversation 0 Commits 1 Files changed 2 +54 -6
dstepanov-yadro commented 2025-03-24 12:36:19 +00:00
Member
Copy link

Let's assume that for some tag limit = 1000 RPS defined and each
request takes 10 ms to complete. At some point in time 1000 requests
were accepted. Then first request will be scheduled at now(), second -
at now() + 1 ms, third - at now() + 2 ms etc. Total processing
duration of 1000 requests will be 1 second + 10 ms.

After this fix scheduler looks forward to schedule requests within limit.
So for situation above total processing duration of 1000 requests will be
10 ms in ideal world.

The same for reservation scheduling.

Let's assume that for some tag `limit = 1000 RPS` defined and each request takes 10 ms to complete. At some point in time 1000 requests were accepted. Then first request will be scheduled at `now()`, second - at `now() + 1 ms`, third - at `now() + 2 ms` etc. Total processing duration of 1000 requests will be 1 second + 10 ms. After this fix scheduler looks forward to schedule requests within limit. So for situation above total processing duration of 1000 requests will be 10 ms in ideal world. The same for reservation scheduling.
dstepanov-yadro added 1 commit 2025-03-24 12:36:19 +00:00
[#9999] mclock: Schedule by limit requests as soon as possible
All checks were successful
DCO action / DCO (pull_request) Successful in 24s
Details
Vulncheck / Vulncheck (pull_request) Successful in 31s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m10s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m4s
Details
Tests and linters / Lint (pull_request) Successful in 1m12s
Details
Tests and linters / gopls check (pull_request) Successful in 1m11s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m18s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m30s
Details
Tests and linters / Tests (pull_request) Successful in 1m3s
Details
41690c21e5 
Let's assume that for some tag `limit = 1000 RPS` defined and each
request takes 10 ms to complete. At some point in time 1000 requests
were accepted. Then first request will be scheduled at `now()`, second -
at `now() + 1 ms`, third - at `now() + 2 ms` etc. Total processing
duration of 1000 requests will be 1 second + 10 ms.

After this fix scheduler looks forward to schedule requests within limit.
So for situation above total processing duration of 1000 requests will be
10 ms in ideal world.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/limit_scheduling from 41690c21e5 to a19b28337c 2025-03-24 12:37:21 +00:00 Compare
dstepanov-yadro force-pushed fix/limit_scheduling from a19b28337c to 57d895c321 2025-03-24 13:37:20 +00:00 Compare
dstepanov-yadro changed title from WIP: Schedule by limit requests as soon as possible to WIP: Schedule requests as soon as possible 2025-03-24 13:39:14 +00:00
dstepanov-yadro changed title from WIP: Schedule requests as soon as possible to Schedule requests as soon as possible 2025-03-28 08:13:39 +00:00
requested reviews from fyrchik, storage-core-committers, storage-core-developers 2025-03-28 08:13:52 +00:00
aarifullin approved these changes 2025-03-28 08:28:37 +00:00
acid-ant approved these changes 2025-03-28 08:53:11 +00:00
dstepanov-yadro merged commit 57d895c321 into master 2025-03-28 10:06:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
acid-ant
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-qos#13
No description provided.
Delete branch "dstepanov-yadro/frostfs-qos:fix/limit_scheduling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?