TrueCloudLab/frostfs-qos

Allow set `LimitIOPS = 0` #14

New issue

Closed

opened 2025-03-26 11:14:35 +00:00 by dstepanov-yadro · 0 comments

dstepanov-yadro commented

2025-03-26 11:14:35 +00:00

Member

Expected Behavior

If I define LimitIOPS as not nill, but equals 0, then I expect, that operations with this tag will be prohibited (error will be returned).

Current Behavior

Scheduler doesn't allow 0 as LimitIOPS value:

if v.LimitIOPS != nil && (math.IsNaN(*v.LimitIOPS) || *v.LimitIOPS <= float64(0)) {

## Expected Behavior If I define `LimitIOPS` as not nill, but equals 0, then I expect, that operations with this tag will be prohibited (error will be returned). ## Current Behavior Scheduler doesn't allow 0 as `LimitIOPS` value: https://git.frostfs.info/TrueCloudLab/frostfs-qos/src/commit/32079ad7c2752b2ee1ed89c927e11418b641655a/scheduling/mclock.go#L156

dstepanov-yadro added the

label 2025-03-26 11:14:35 +00:00

dstepanov-yadro referenced this issue from a pull request that will close it,

2025-03-28 10:42:29 +00:00

Allow to restrict tag requests #15

dstepanov-yadro closed this issue

2025-03-31 08:08:15 +00:00

dstepanov-yadro referenced this issue from a commit

2025-03-31 08:08:15 +00:00

[#14] mclock: Allow to prohibit tag requests

dstepanov-yadro referenced this issue from a commit

2025-03-31 08:08:15 +00:00

[#14] CODEOWNERS: Use core commiters and developers groups

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-qos#14

No description provided.