TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

Add missing error checks

Browse source
This commit is contained in:
Pavel Korotkov 2020-07-21 12:28:00 +03:00
parent e4f7a702dc
commit 6c0ddca8d0
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
auth/center.go
View file

@ -152,7 +152,7 @@ func (center *Center) AuthenticationPassed(request *http.Request) (*service.Bear
} }
signatureDateTime, err := time.Parse("20060102T150405Z", request.Header.Get("X-Amz-Date")) signatureDateTime, err := time.Parse("20060102T150405Z", request.Header.Get("X-Amz-Date"))
if err != nil { if err != nil {
// TODO return nil, errors.Wrap(err, "failed to parse x-amz-date header field")
} }
accessKeyID := sms1["access_key_id"] accessKeyID := sms1["access_key_id"]
bearerToken, secretAccessKey, err := center.unpackBearerToken(accessKeyID) bearerToken, secretAccessKey, err := center.unpackBearerToken(accessKeyID)
@ -174,11 +174,11 @@ func (center *Center) AuthenticationPassed(request *http.Request) (*service.Bear
signer := v4.NewSigner(awsCreds) signer := v4.NewSigner(awsCreds)
body, err := readAndKeepBody(request) body, err := readAndKeepBody(request)
if err != nil { if err != nil {
// TODO return nil, errors.Wrap(err, "failed to read out request body")
} }
_, err = signer.Sign(otherRequest, body, sms1["service"], sms1["region"], signatureDateTime) _, err = signer.Sign(otherRequest, body, sms1["service"], sms1["region"], signatureDateTime)
if err != nil { if err != nil {
// TODO return nil, errors.Wrap(err, "failed to sign temporary HTTP request")
} }
sms2 := center.submatcher.getSubmatches(otherRequest.Header.Get("Authorization")) sms2 := center.submatcher.getSubmatches(otherRequest.Header.Get("Authorization"))
if sms1["v4_signature"] != sms2["v4_signature"] { if sms1["v4_signature"] != sms2["v4_signature"] {