Use request ID in all log records produced by S3 request #111

Closed
opened 2023-05-17 12:34:51 +00:00 by alexvanin · 3 comments
Owner

Every S3 request contains request ID in the header. It will be much easier to debug issues by looking for logs with specific request ID.

Describe the solution you'd like

Pass request ID in the context and use it in logs. Contexts will be useful for #84

Describe alternatives you've considered

Create custom zap.Logger instance with preset field for each request.

## Is your feature request related to a problem? Please describe. Every S3 request contains request ID in the header. It will be much easier to debug issues by looking for logs with specific request ID. ## Describe the solution you'd like Pass request ID in the context and use it in logs. Contexts will be useful for #84 ## Describe alternatives you've considered Create custom zap.Logger instance with preset field for each request.
alexvanin added the
enhancement
good first issue
labels 2023-05-17 12:34:58 +00:00
Author
Owner

Also check all log levels for messages during startup, see #109 (comment)

Also check all log levels for messages during startup, see https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/109#issuecomment-9639
Author
Owner

Also consider this issue as an epic for log improvements.

Add keybox address in fetching errors, see

error        api/user_auth.go:33        failed to pass authentication        {"error": "get box: get access box: read payload: init full payload range reading via connection pool: read header: status: code = 3072 message = container not found"}
Also consider this issue as an epic for log improvements. Add keybox address in fetching errors, see ``` error api/user_auth.go:33 failed to pass authentication {"error": "get box: get access box: read payload: init full payload range reading via connection pool: read header: status: code = 3072 message = container not found"} ```
Member

Also, it would be nice to log request at the beginning (can be useful for long requests, now we can see something only in the end of the request)

Also, it would be nice to log request at the beginning (can be useful for long requests, now we can see something only in the end of the request)
dkirillov was assigned by alexvanin 2023-06-02 13:41:41 +00:00
alexvanin added this to the v0.28.0 milestone 2023-07-12 09:39:58 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#111
No description provided.