Use request ID in all log records produced by S3 request #111
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#111
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is your feature request related to a problem? Please describe.
Every S3 request contains request ID in the header. It will be much easier to debug issues by looking for logs with specific request ID.
Describe the solution you'd like
Pass request ID in the context and use it in logs. Contexts will be useful for #84
Describe alternatives you've considered
Create custom zap.Logger instance with preset field for each request.
Also check all log levels for messages during startup, see #109 (comment)
Also consider this issue as an epic for log improvements.
Add keybox address in fetching errors, see
Also, it would be nice to log request at the beginning (can be useful for long requests, now we can see something only in the end of the request)