Gernalize fetch and parse config parameter functions #117

Closed
opened 2023-05-23 08:23:39 +00:00 by alexvanin · 1 comment

S3 Gateway codebase contains different fetching / parsing functions for parameters. There are several different cases when they are used:

  1. read/parse parameter once and fail if it is invalid,
  2. read/parse parameter once and use default if it is invalid,
  3. read/parse parameter and fail if it is invalid and avoid reloading on SIGHUP failure,
  4. read/parse parameter and use default on start and avoid reloading on SIGHUP failure.

Describe the solution you'd like

Generalize config reading functions / parsers for all these cases.

Describe alternatives you've considered

Additional context

## Is your feature request related to a problem? Please describe. S3 Gateway codebase contains different fetching / parsing functions for parameters. There are several different cases when they are used: 1. read/parse parameter once and fail if it is invalid, 2. read/parse parameter once and use default if it is invalid, 3. read/parse parameter and fail if it is invalid and avoid reloading on SIGHUP failure, 4. read/parse parameter and use default on start and avoid reloading on SIGHUP failure. ## Describe the solution you'd like Generalize config reading functions / parsers for all these cases. ## Describe alternatives you've considered <!--- A clear and concise description of any alternative solutions or features you've considered. --> ## Additional context <!--- Add any other context or screenshots about the feature request here. -->
alexvanin added the
good first issue
refactoring
labels 2023-05-23 08:23:39 +00:00
r.loginov self-assigned this 2023-08-17 14:43:15 +00:00
Poster
Owner

Closed by #189

Closed by #189
alexvanin added this to the v0.28.0 milestone 2023-09-08 13:06:51 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#117
There is no content yet.