TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 13
Code Issues 24 Pull Requests 8 Actions Packages Releases 3 Activity

Enable forgejo CI #122

Merged
alexvanin merged 1 commits from alexvanin/frostfs-s3-gw:ci into master 2023-07-26 21:08:01 +00:00
Conversation 0 Commits 1 Files Changed 7
alexvanin commented 2023-05-31 16:31:21 +00:00
Owner
There is no content yet.
alexvanin force-pushed ci from 41e963a0bb to 81e860481d 2023-05-31 16:43:42 +00:00 Compare
alexvanin requested review from storage-services-committers 2023-05-31 16:57:47 +00:00
alexvanin requested review from storage-services-developers 2023-05-31 16:57:47 +00:00
dkirillov reviewed 2023-06-01 06:24:26 +00:00
api/auth/signer/v4/v4.go
@ -791,2 +791,4 @@
// stripExcessSpaces will rewrite the passed in slice's string values to not
// contain multiple side-by-side spaces.
//
//nolint:revive
dkirillov commented 2023-06-01 06:24:26 +00:00
Collaborator

Just wondering why is Revival complaining about this function?

Just wondering why is Revival complaining about this function?
alexvanin commented 2023-06-01 06:43:00 +00:00
Poster
Owner

It does not like for loops with empty block, even though they modify j and k variables.

// revive  empty-block: this block is empty, you can remove it
for j = len(str) - 1; j >= 0 && str[j] == ' '; j-- {
}
It does not like for loops with empty block, even though they modify `j` and `k` variables. ```go // revive empty-block: this block is empty, you can remove it for j = len(str) - 1; j >= 0 && str[j] == ' '; j-- { } ```
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-06-01 06:24:39 +00:00
alexvanin merged commit 81e860481d into master 2023-06-01 12:23:09 +00:00
alexvanin deleted branch ci 2023-06-01 12:23:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#122
There is no content yet.
Delete Branch "alexvanin/frostfs-s3-gw:ci"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?