TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 28 Pull requests 9 Projects Releases 26 Packages 1 Activity Actions

Refactor the context-stored data retrievers #137

New issue
Closed
opened 2023-06-13 14:14:43 +00:00 by ironbee · 1 comment
ironbee commented 2023-06-13 14:14:43 +00:00
Contributor
Copy link

We have quite a few places where the context gets queried for certain stored values. These places can be found by checking usages of key like this one: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/api/user_auth.go#L17

Let's think of a way to refactor them and get together in one place.

We have quite a few places where the context gets queried for certain stored values. These places can be found by checking usages of key like this one: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/api/user_auth.go#L17 Let's think of a way to refactor them and get together in one place.
ironbee added the
discussion
 label 2023-06-13 14:14:43 +00:00
r.loginov self-assigned this 2023-08-14 08:09:52 +00:00
dkirillov commented 2023-08-16 14:06:20 +00:00
Member
Copy link

done in #183

done in #183
alexvanin added this to the v0.28.0 milestone 2023-09-08 12:03:09 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.32
support/v0.31
support/v0.30
support/v0.29
support/v0.28
support/v0.27
v0.32.3
v0.32.2
v0.32.1
v0.33.0-pre
v0.32.0
v0.31.3
v0.31.2
v0.30.9
v0.31.1
v0.31.0
v0.31.0-rc.6
v0.31.0-rc.5
v0.31.0-rc.4
v0.30.8
v0.31.0-rc.3
v0.30.7
v0.31.0-rc.2
v0.31.0-rc.1
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.30.0-rc.5
v0.29.2
v0.30.0-rc.4
v0.30.0-rc.3
v0.30.0-rc.2
v0.29.1
v0.30.0-rc.1
v0.29.0
v0.28.2
v0.29.0-rc.11
v0.29.0-rc.10
v0.29.0-rc.9
v0.29.0-rc.8
v0.29.0-rc.7
v0.29.0-rc.6
v0.29.0-rc.5
v0.29.0-rc.4
v0.29.0-rc.3
v0.29.0-rc.2
v0.29.0-rc.1
v0.28.1
v0.28.0
v0.28.0-rc.1
v0.27.0
v0.27.0-rc.2
v0.27.0-rc.1
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.28.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#137
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?