TrueCloudLab
/
frostfs-s3-gw
15
2
Fork 14
Code Issues 20 Pull Requests 5 Actions Packages Releases 6 Activity

Use gRPC interceptor from observability package #140

Merged
alexvanin merged 1 commits from alexvanin/frostfs-s3-gw:feature/use-trace-interceptor into master 2023-06-14 15:46:44 +00:00
Conversation 0 Commits 1 Files Changed 1
alexvanin commented 2023-06-14 09:15:11 +00:00
Owner

Previous SDK implementation had implicit gRPC interceptor
for tracing. Now pool constructors allow any dial options,
so gateway should manually pass tracing interceptors from
observability package.

Previous SDK implementation had implicit gRPC interceptor for tracing. Now pool constructors allow any dial options, so gateway should manually pass tracing interceptors from observability package.
alexvanin self-assigned this 2023-06-14 09:15:11 +00:00
alexvanin force-pushed feature/use-trace-interceptor from a8d4020769 to 003565bcef 2023-06-14 09:16:05 +00:00 Compare
dkirillov reviewed 2023-06-14 09:18:46 +00:00
cmd/s3-gw/app.go Outdated
@ -314,0 +323,4 @@
apiGRPCDialOpts = append(apiGRPCDialOpts, interceptors...)
}
prm.SetGRPCDialOptions(apiGRPCDialOpts...)
prmTree.SetGRPCDialOptions(treeGRPCDialOpts...)
dkirillov commented 2023-06-14 09:18:46 +00:00
Collaborator

This will be overridden on line 337

This will be overridden on line 337
alexvanin commented 2023-06-14 09:20:35 +00:00
Poster
Owner

Fixed.

Fixed.
dkirillov marked this conversation as resolved
alexvanin force-pushed feature/use-trace-interceptor from 003565bcef to 67bf8ee8b6 2023-06-14 09:19:53 +00:00 Compare
dkirillov approved these changes 2023-06-14 09:20:53 +00:00
alexvanin requested review from dkirillov 2023-06-14 09:20:59 +00:00
alexvanin requested review from pogpp 2023-06-14 09:20:59 +00:00
alexvanin requested review from ironbee 2023-06-14 09:20:59 +00:00
alexvanin merged commit 751d66bde0 into master 2023-06-14 15:46:44 +00:00
alexvanin deleted branch feature/use-trace-interceptor 2023-06-14 15:46:45 +00:00
alexvanin added this to the v0.28.0 milestone 2023-07-12 09:39:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
pogpp
ironbee
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.28.0
Assignees
Clear assignees
No Assignees
alexvanin
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#140
There is no content yet.
Delete Branch "alexvanin/frostfs-s3-gw:feature/use-trace-interceptor"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?