Don't return `InternalError` if possible #143

New issue

Closed

opened 2023-06-16 07:39:44 +00:00 by dkirillov · 1 comment

dkirillov commented

2023-06-16 07:39:44 +00:00

Member

We have function that forms s3 errors to return to the client.
And if the error is already well formed s3 error it's returned as is.

But sometimes initial error is wrapped and we get InternalError

Expected Behavior

Getting EntityTooSmall error

Current Behavior

Getting InternalError error

Possible Solution

Unwrap s3 errors here before checking

Steps to Reproduce (for bugs)

Init multipart upload
Upload two parts with size less than 5mb
Try to complete multipart upload

Your Environment

Version used: 751d66bde0

We have function that [forms s3 errors](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/751d66bde0bf94c7a59b68c188ef11a289f68bc3/api/handler/util.go#L45) to return to the client. And if the error is already well formed s3 error it's returned as is. But sometimes [initial error](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/751d66bde0bf94c7a59b68c188ef11a289f68bc3/api/layer/multipart_upload.go#L393) is [wrapped](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/751d66bde0bf94c7a59b68c188ef11a289f68bc3/api/handler/multipart_upload.go#L448-L451) and we get `InternalError` ## Expected Behavior Getting `EntityTooSmall` error ## Current Behavior Getting `InternalError` error ## Possible Solution Unwrap s3 errors [here](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/751d66bde0bf94c7a59b68c188ef11a289f68bc3/api/handler/util.go#L46) before checking ## Steps to Reproduce (for bugs) 1. Init multipart upload 2. Upload two parts with size less than 5mb 3. Try to complete multipart upload ## Your Environment * Version used: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/commit/751d66bde0bf94c7a59b68c188ef11a289f68bc3

👍 2