TrueCloudLab/frostfs-s3-gw

Rename `accessKey` to `secretKey` #154

New issue

Closed

opened 2023-06-27 13:06:18 +00:00 by alexvanin · 1 comment

alexvanin commented

2023-06-27 13:06:18 +00:00

Owner

Access box stores encoded secret key to check signatures. However it is called accessKey in the protobuf and corresponding definitions which is very similar to access_key_id of S3 protocol.

To avoid confusion I propose to rename accessKey statements to secretKey once and for all. This change should be compatible, because access boxes are stored in binary form.

Access box stores encoded secret key to check signatures. However it is called [accessKey](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/2cbe3b9a27c22307450166053ff0513fdca70c29/creds/accessbox/accessbox.proto#L26) in the protobuf and corresponding definitions which is _very_ similar to `access_key_id` of S3 protocol. To avoid confusion I propose to rename `accessKey` statements to `secretKey` once and for all. This change should be compatible, because access boxes are stored in binary form.

alexvanin added the

label 2023-06-27 13:06:18 +00:00

alexvanin commented

2023-06-27 13:11:59 +00:00

Author

Owner

For some reason we do have json_name definitions though. I am not sure there are any usage of that besides an output of authmate app.

For some reason we do have `json_name` definitions though. I am not sure there are any usage of that besides an output of authmate app.

r.loginov was assigned by alexvanin

2023-09-19 11:09:54 +00:00

~~r.loginov referenced this issue 2023-10-02 09:58:20 +00:00~~

[#154] Rename access key to secret key #229

r.loginov referenced this issue from a pull request that will close it,

2023-10-02 10:19:48 +00:00

[#154] Rename access key to secret key #229

alexvanin closed this issue

2023-10-06 09:20:40 +00:00

alexvanin referenced this issue from a commit

2023-10-06 09:20:42 +00:00

[#154] Rename access key to secret key

r.loginov referenced this issue

2023-10-06 11:41:45 +00:00

[#154] Rename OwnerPublicKey to SeedKey #232

alexvanin referenced this issue from a commit

2023-10-11 12:31:45 +00:00

[#154] Rename OwnerPublicKey to SeedKey

alexvanin added this to the v0.29.0 milestone 2023-12-07 12:57:15 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#154

No description provided.