Convert handler config to interface #172

New Issue

Closed

opened 2023-07-18 11:06:30 +00:00 by dkirillov · 0 comments

dkirillov commented

2023-07-18 11:06:30 +00:00

Collaborator

We have a lot of parameters that should be reloaded by SIGHUP. So currently we have several structs that implements several interfaces. So each struct must have some synchronization primitives (mutex or atomic). It's getting harder to maintain such solution especially because pass config params as struct

Describe the solution you'd like

I suggest convert config to interface and make settings to implement it. We can use only one sync.RWMutex and it will be easy to add new params.

Describe alternatives you've considered

Continue using current approach.

Additional context

## Is your feature request related to a problem? Please describe. We have a lot of parameters that should be reloaded by SIGHUP. So currently we have [several](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/cmd/s3-gw/app.go#L84) [structs](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/internal/xml/decoder.go#L11) that implements [several](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/api/handler/api.go#L42) [interfaces](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/api/handler/api.go#L49). So each struct must have some synchronization primitives (mutex or atomic). It's getting harder to maintain such solution especially because pass config params as [struct](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/api/handler/api.go#L32) ## Describe the solution you'd like I suggest convert [config](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/api/handler/api.go#L32) to interface and make [settings](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/14ef9ff091829487882d6f774e8e931399f8b2cb/cmd/s3-gw/app.go#L67) to implement it. We can use only one `sync.RWMutex` and it will be easy to add new params. ## Describe alternatives you've considered Continue using current approach. ## Additional context no