TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 13
Code Issues 24 Pull Requests 8 Actions Packages Releases 3 Activity

Add node addresses metric #186

Merged
dkirillov merged 2 commits from ironbee/frostfs-s3-gw:add-node-addresses-metric into master 2023-08-17 12:24:31 +00:00
Conversation 0 Commits 2 Files Changed 12
ironbee commented 2023-08-16 13:33:13 +00:00
Collaborator

Closes #51

Closes #51
ironbee requested review from storage-services-committers 2023-08-16 13:34:00 +00:00
ironbee requested review from storage-services-developers 2023-08-16 13:34:01 +00:00
ironbee force-pushed add-node-addresses-metric from 8eb42e982e to e344106c9f 2023-08-16 14:09:09 +00:00 Compare
ironbee self-assigned this 2023-08-16 14:34:23 +00:00
dkirillov reviewed 2023-08-16 14:36:38 +00:00
metrics/pool.go Outdated
@ -42,6 +43,7 @@ type poolMetricsCollector struct {
overallNodeRequests *prometheus.GaugeVec
currentErrors *prometheus.GaugeVec
requestDuration *prometheus.GaugeVec
currenNodes *prometheus.GaugeVec
dkirillov commented 2023-08-16 14:36:38 +00:00
Collaborator

Typo: must be currentNodes

Typo: must be `currentNodes`
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-08-16 14:37:20 +00:00
ironbee force-pushed add-node-addresses-metric from e344106c9f to acde45ef96 2023-08-17 07:10:54 +00:00 Compare
dkirillov approved these changes 2023-08-17 07:24:19 +00:00
pogpp approved these changes 2023-08-17 11:14:33 +00:00
ironbee force-pushed add-node-addresses-metric from acde45ef96 to c750c87a61 2023-08-17 11:26:33 +00:00 Compare
dkirillov approved these changes 2023-08-17 11:55:39 +00:00
pogpp approved these changes 2023-08-17 12:19:14 +00:00
dkirillov merged commit c750c87a61 into master 2023-08-17 12:24:31 +00:00
alexvanin added this to the v0.28.0 milestone 2023-11-23 14:55:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
pogpp
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.28.0
Assignees
Clear assignees
No Assignees
ironbee
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#186
There is no content yet.
Delete Branch "ironbee/frostfs-s3-gw:add-node-addresses-metric"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?