TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 9 Projects Releases 23 Packages Activity Actions 4

[#96] Move log messages to constants #194

Merged
alexvanin merged 1 commit from :feature/3978-move_logs_to_constants into master 2023-08-24 13:47:12 +00:00
Conversation 2 Commits 1 Files changed 39 +289 -137
r.loginov commented 2023-08-23 11:45:58 +00:00
Member
Copy link

Signed-off-by: Roman Loginov r.loginov@yadro.com

Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov self-assigned this 2023-08-23 11:45:58 +00:00
r.loginov requested review from storage-services-committers 2023-08-23 11:57:19 +00:00
r.loginov requested review from storage-services-developers 2023-08-23 11:57:22 +00:00
dkirillov reviewed 2023-08-23 13:14:00 +00:00
internal/logs/logs.go Outdated
@ -0,0 +8,4 @@
* software and the intellectual property contained therein is expressly
* limited to the terms and conditions of the License Agreement under which
* it is provided by YADRO.
*/
dkirillov commented 2023-08-23 13:14:00 +00:00
Member
Copy link

In public repositories we don't need this Copyright

In public repositories we don't need this Copyright
dkirillov marked this conversation as resolved
r.loginov force-pushed feature/3978-move_logs_to_constants from bdc78de601 to 9aa698dda2 2023-08-23 13:19:31 +00:00 Compare
dkirillov commented 2023-08-23 14:30:55 +00:00
Member
Copy link

Let's rewrite this to a.log.Warn("resolver 'nns' won't be used since 'rpc_endpoint' isn't provided") and move it to constant too

Let's rewrite [this](https://git.frostfs.info/r.loginov/frostfs-s3-gw/src/commit/9aa698dda20a3ce4a286977f5a7ebdcaa77c5aa5/cmd/s3-gw/app.go#L230) to `a.log.Warn("resolver 'nns' won't be used since 'rpc_endpoint' isn't provided")` and move it to constant too
r.loginov force-pushed feature/3978-move_logs_to_constants from 9aa698dda2 to 8efcc957ea 2023-08-23 15:34:35 +00:00 Compare
dkirillov approved these changes 2023-08-24 06:29:13 +00:00
fyrchik commented 2023-08-24 08:23:01 +00:00
Owner
Copy link

We also have a linter which can help catching this problems in future https://git.frostfs.info/TrueCloudLab/linters/#user-content-noliteral

We also have a linter which can help catching this problems in future https://git.frostfs.info/TrueCloudLab/linters/#user-content-noliteral
👍 2
alexvanin approved these changes 2023-08-24 13:47:02 +00:00
alexvanin merged commit 8efcc957ea into master 2023-08-24 13:47:12 +00:00
alexvanin deleted branch feature/3978-move_logs_to_constants 2023-08-24 13:47:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#194
No description provided.
Delete branch ":feature/3978-move_logs_to_constants"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?