TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

[#207] Fix list parts with empty list #213

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:bugfix/list_parts_empty_list into master 2023-09-21 14:48:14 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
mbiryukova commented 2023-09-21 08:30:05 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-09-21 08:30:05 +00:00
mbiryukova added 1 commit 2023-09-21 08:30:07 +00:00
[#207] Fix list parts with empty list
All checks were successful
/ DCO (pull_request) Successful in 1m2s
Details
/ Vulncheck (pull_request) Successful in 1m25s
Details
/ Builds (1.20) (pull_request) Successful in 1m59s
Details
/ Builds (1.21) (pull_request) Successful in 1m52s
Details
/ Lint (pull_request) Successful in 8m23s
Details
/ Tests (1.20) (pull_request) Successful in 2m1s
Details
/ Tests (1.21) (pull_request) Successful in 9m26s
Details
51e591877b 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2023-09-21 09:00:37 +00:00
mbiryukova requested review from storage-services-developers 2023-09-21 09:00:38 +00:00
alexvanin approved these changes 2023-09-21 11:01:38 +00:00
dkirillov reviewed 2023-09-21 12:05:21 +00:00
api/layer/multipart_upload.go
@ -549,3 +549,3 @@
})
if p.PartNumberMarker >= parts[len(parts)-1].PartNumber {
if len(parts) == 0 || p.PartNumberMarker >= parts[len(parts)-1].PartNumber {
dkirillov commented 2023-09-21 12:05:21 +00:00
Member
Copy link

Do we really need this? It seems without such condition we will get the same result below. Or am I missing something?

Do we really need this? It seems without such condition we will get the same result below. Or am I missing something?
mbiryukova commented 2023-09-21 12:48:56 +00:00
Author
Member
Copy link

Without this condition we will get panic here parts[len(parts)-1] if length of parts is 0

Without this condition we will get panic here `parts[len(parts)-1]` if length of parts is 0
dkirillov commented 2023-09-21 12:53:39 +00:00
Member
Copy link

Oh, I see.

Oh, I see.
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-09-21 12:54:00 +00:00
alexvanin merged commit 51e591877b into master 2023-09-21 14:48:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#213
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:bugfix/list_parts_empty_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?