Fix flaky PeriodicWriter test #249

New issue

Closed

opened 2023-10-26 07:35:28 +00:00 by alexvanin · 2 comments

alexvanin commented

2023-10-26 07:35:28 +00:00

Owner

v0.28.0-rc.1-8-gff5c55e1

[2023-10-25T21:30:10.463Z] --- FAIL: TestPeriodicWriter (0.90s)
[2023-10-25T21:30:10.463Z]     --- FAIL: TestPeriodicWriter/writes_data (0.85s)
[2023-10-25T21:30:10.463Z]         multipart_upload_test.go:38: 
[2023-10-25T21:30:10.463Z]             	Error Trace:	/home/ci/jenkins_home/workspace/Bundle_frostfs_build_NB/frostfs-s3-gw/api/handler/multipart_upload_test.go:38
[2023-10-25T21:30:10.463Z]             	Error:      	Not equal: 
[2023-10-25T21:30:10.463Z]             	            	expected: []byte{0x3c, 0x3f, 0x78, 0x6d, 0x6c, 0x20, 0x76, 0x65, 0x72, 0x73, 0x69, 0x6f, 0x6e, 0x3d, 0x22, 0x31, 0x2e, 0x30, 0x22, 0x20, 0x65, 0x6e, 0x63, 0x6f, 0x64, 0x69, 0x6e, 0x67, 0x3d, 0x22, 0x55, 0x54, 0x46, 0x2d, 0x38, 0x22, 0x3f, 0x3e, 0xa, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20}
[2023-10-25T21:30:10.463Z]             	            	actual  : []byte{0x3c, 0x3f, 0x78, 0x6d, 0x6c, 0x20, 0x76, 0x65, 0x72, 0x73, 0x69, 0x6f, 0x6e, 0x3d, 0x22, 0x31, 0x2e, 0x30, 0x22, 0x20, 0x65, 0x6e, 0x63, 0x6f, 0x64, 0x69, 0x6e, 0x67, 0x3d, 0x22, 0x55, 0x54, 0x46, 0x2d, 0x38, 0x22, 0x3f, 0x3e, 0xa, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20}
[2023-10-25T21:30:10.463Z]             	            	
[2023-10-25T21:30:10.463Z]             	            	Diff:
[2023-10-25T21:30:10.463Z]             	            	--- Expected
[2023-10-25T21:30:10.463Z]             	            	+++ Actual
[2023-10-25T21:30:10.463Z]             	            	@@ -1,5 +1,5 @@
[2023-10-25T21:30:10.463Z]             	            	-([]uint8) (len=47) {
[2023-10-25T21:30:10.463Z]             	            	+([]uint8) (len=46) {
[2023-10-25T21:30:10.463Z]             	            	  00000000  3c 3f 78 6d 6c 20 76 65  72 73 69 6f 6e 3d 22 31  |<?xml version="1|
[2023-10-25T21:30:10.463Z]             	            	  00000010  2e 30 22 20 65 6e 63 6f  64 69 6e 67 3d 22 55 54  |.0" encoding="UT|
[2023-10-25T21:30:10.463Z]             	            	- 00000020  46 2d 38 22 3f 3e 0a 20  20 20 20 20 20 20 20     |F-8"?>.        |
[2023-10-25T21:30:10.463Z]             	            	+ 00000020  46 2d 38 22 3f 3e 0a 20  20 20 20 20 20 20        |F-8"?>.       |
[2023-10-25T21:30:10.463Z]             	            	 }
[2023-10-25T21:30:10.463Z]             	Test:       	TestPeriodicWriter/writes_data

v0.28.0-rc.1-8-gff5c55e1 ``` [2023-10-25T21:30:10.463Z] --- FAIL: TestPeriodicWriter (0.90s) [2023-10-25T21:30:10.463Z] --- FAIL: TestPeriodicWriter/writes_data (0.85s) [2023-10-25T21:30:10.463Z] multipart_upload_test.go:38: [2023-10-25T21:30:10.463Z] Error Trace: /home/ci/jenkins_home/workspace/Bundle_frostfs_build_NB/frostfs-s3-gw/api/handler/multipart_upload_test.go:38 [2023-10-25T21:30:10.463Z] Error: Not equal: [2023-10-25T21:30:10.463Z] expected: []byte{0x3c, 0x3f, 0x78, 0x6d, 0x6c, 0x20, 0x76, 0x65, 0x72, 0x73, 0x69, 0x6f, 0x6e, 0x3d, 0x22, 0x31, 0x2e, 0x30, 0x22, 0x20, 0x65, 0x6e, 0x63, 0x6f, 0x64, 0x69, 0x6e, 0x67, 0x3d, 0x22, 0x55, 0x54, 0x46, 0x2d, 0x38, 0x22, 0x3f, 0x3e, 0xa, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20} [2023-10-25T21:30:10.463Z] actual : []byte{0x3c, 0x3f, 0x78, 0x6d, 0x6c, 0x20, 0x76, 0x65, 0x72, 0x73, 0x69, 0x6f, 0x6e, 0x3d, 0x22, 0x31, 0x2e, 0x30, 0x22, 0x20, 0x65, 0x6e, 0x63, 0x6f, 0x64, 0x69, 0x6e, 0x67, 0x3d, 0x22, 0x55, 0x54, 0x46, 0x2d, 0x38, 0x22, 0x3f, 0x3e, 0xa, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20} [2023-10-25T21:30:10.463Z] [2023-10-25T21:30:10.463Z] Diff: [2023-10-25T21:30:10.463Z] --- Expected [2023-10-25T21:30:10.463Z] +++ Actual [2023-10-25T21:30:10.463Z] @@ -1,5 +1,5 @@ [2023-10-25T21:30:10.463Z] -([]uint8) (len=47) { [2023-10-25T21:30:10.463Z] +([]uint8) (len=46) { [2023-10-25T21:30:10.463Z] 00000000 3c 3f 78 6d 6c 20 76 65 72 73 69 6f 6e 3d 22 31 |<?xml version="1| [2023-10-25T21:30:10.463Z] 00000010 2e 30 22 20 65 6e 63 6f 64 69 6e 67 3d 22 55 54 |.0" encoding="UT| [2023-10-25T21:30:10.463Z] - 00000020 46 2d 38 22 3f 3e 0a 20 20 20 20 20 20 20 20 |F-8"?>. | [2023-10-25T21:30:10.463Z] + 00000020 46 2d 38 22 3f 3e 0a 20 20 20 20 20 20 20 |F-8"?>. | [2023-10-25T21:30:10.463Z] } [2023-10-25T21:30:10.463Z] Test: TestPeriodicWriter/writes_data ```

alexvanin referenced this issue from a commit

2023-10-26 08:03:29 +00:00

[#249] Skip flaky test

dkirillov commented

2023-10-27 06:55:57 +00:00

Member

Probably we can drop this test at all. It seems after #227 we will stop using periodic writer (now complete multipart upload quick enough).

Probably we can drop this test at all. It seems after https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/issues/227 we will stop using periodic writer (now complete multipart upload quick enough).

alexvanin commented

2023-10-31 13:36:00 +00:00

Author

Owner