TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 22 Pull requests 5 Projects Releases 16 Packages Activity Actions

[TrueCloudLab#28] Add generated deb builder files to gitignore, and fix typo #30

Merged
Alexpast1423 merged 1 commit from master into master 2023-02-15 07:25:46 +00:00
Conversation 0 Commits 1 Files changed 3 +10 -2
Alexpast1423 commented 2023-02-13 15:17:59 +00:00 (Migrated from github.com)
Copy link

Now after build debian package, we see "dirty" suffix in version, example:

neofs-node --version
NeoFS Storage node
Version: v0.35.0-43-g3209d746-dirty
GoVersion: go1.18.4

It's happens because make debpackage download all dependencies in work directory, and after download git directory have uncommited changes. All changes are placed in debian folder and i'm solve this problem after add this files in .gitignore

Signed-off-by: Aleksey Pastukhov a.pastukhov@yadro.com

Now after build debian package, we see "dirty" suffix in version, example: ``` neofs-node --version NeoFS Storage node Version: v0.35.0-43-g3209d746-dirty GoVersion: go1.18.4 ``` It's happens because ```make debpackage``` download all dependencies in work directory, and after download git directory have uncommited changes. All changes are placed in debian folder and i'm solve this problem after add this files in .gitignore Signed-off-by: Aleksey Pastukhov <a.pastukhov@yadro.com>
DmitryZabolotsky (Migrated from github.com) reviewed 2023-02-13 15:17:59 +00:00
KirillovDenis (Migrated from github.com) reviewed 2023-02-14 06:59:12 +00:00
CHANGELOG.md
@ -16,6 +16,7 @@ This document outlines major changes between releases.
- Update go version to go1.18 (TrueCloudLab#16)
KirillovDenis (Migrated from github.com) commented 2023-02-14 06:59:11 +00:00
Copy link

Please use (TrueCloudLab#28)

Please use `(TrueCloudLab#28)`
KirillovDenis (Migrated from github.com) reviewed 2023-02-14 07:41:59 +00:00
debian/changelog
@ -1,4 +1,4 @@
forstfs-s3-gw (0.0.0) stable; urgency=medium
frostfs-s3-gw (0.0.0) stable; urgency=medium
KirillovDenis (Migrated from github.com) commented 2023-02-14 07:41:59 +00:00
Copy link

Do we need this file (debian/changelog) to be committed if we added it to .gitignore?

Do we need this file (`debian/changelog`) to be committed if we added it to `.gitignore`?
Alexpast1423 (Migrated from github.com) reviewed 2023-02-14 10:46:47 +00:00
debian/changelog
@ -1,4 +1,4 @@
forstfs-s3-gw (0.0.0) stable; urgency=medium
frostfs-s3-gw (0.0.0) stable; urgency=medium
Alexpast1423 (Migrated from github.com) commented 2023-02-14 10:46:47 +00:00
Copy link

This file need for locally build debian packages

This file need for locally build debian packages
KirillovDenis (Migrated from github.com) reviewed 2023-02-14 10:57:39 +00:00
.gitignore
KirillovDenis (Migrated from github.com) commented 2023-02-14 10:57:38 +00:00
Copy link

Please, don't delete newline at the end file

Please, don't delete newline at the end file
KirillovDenis (Migrated from github.com) approved these changes 2023-02-14 11:41:38 +00:00
alexvanin (Migrated from github.com) approved these changes 2023-02-15 07:25:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
DmitryZabolotsky
KirillovDenis
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#30
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?