TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

Update linter versions #308

Merged
alexvanin merged 2 commits from alexvanin/frostfs-s3-gw:fix/linter-per-pr into master 2024-09-04 19:51:13 +00:00
Conversation 3 Commits 2 Files changed 4 +8 -8
alexvanin commented 2024-02-08 15:07:35 +00:00
Owner
Copy link
No description provided.
fyrchik commented 2024-02-08 15:20:48 +00:00
Owner
Copy link

Just wondering, what was the trigger to do this? Do we have some problems or is it time/resources of the runner?

Just wondering, what was the trigger to do this? Do we have some problems or is it time/resources of the runner?
alexvanin force-pushed fix/linter-per-pr from 9812b2ce9f to 5088448048 2024-02-08 15:26:57 +00:00 Compare
alexvanin commented 2024-02-09 06:21:33 +00:00
Author
Owner
Copy link

Do we have some problems or is it time/resources of the runner?

While TrueCloudLab/linters#16 is in-progress, I decided to see if new-from-rev approach is working, after seeing you using ${{ github.event.pull_request.base.ref }} in dco.yml.

Unfortunately, runner uses fork branches. event.pull_request.base.ref is resolved to origin/master and my forked master branch is a bit outdated. Therefore linter checks multiple commits instead of one in this PR.

> Do we have some problems or is it time/resources of the runner? While https://git.frostfs.info/TrueCloudLab/linters/issues/16 is in-progress, I decided to see if `new-from-rev` approach is working, after seeing you using `${{ github.event.pull_request.base.ref }}` in `dco.yml`. Unfortunately, runner uses fork branches. `event.pull_request.base.ref` is resolved to `origin/master` and my forked `master` branch is a bit outdated. Therefore linter checks multiple commits instead of one in this PR.
alexvanin force-pushed fix/linter-per-pr from 2ea0265160 to b5bcdbe087 2024-02-16 15:20:19 +00:00 Compare
alexvanin force-pushed fix/linter-per-pr from b5bcdbe087 to 563c1d9bd7 2024-02-16 15:25:17 +00:00 Compare
alexvanin commented 2024-02-16 15:32:52 +00:00
Author
Owner
Copy link

With the new linter release, everything works just fine, so I dropped all other changes in this PR.

With the new linter release, everything works just fine, so I dropped all other changes in this PR.
alexvanin changed title from WIP: Use new-from-rev flag for linter check to Use new-from-rev flag for linter check 2024-02-16 15:32:54 +00:00
alexvanin changed title from Use new-from-rev flag for linter check to Update linter versions 2024-02-16 15:33:02 +00:00
alexvanin requested review from dkirillov 2024-02-16 15:33:20 +00:00
alexvanin requested review from pogpp 2024-02-16 15:33:20 +00:00
alexvanin requested review from ironbee 2024-02-16 15:33:20 +00:00
alexvanin requested review from achuprov 2024-02-16 15:33:21 +00:00
alexvanin requested review from mbiryukova 2024-02-16 15:33:21 +00:00
alexvanin requested review from r.loginov 2024-02-16 15:33:21 +00:00
mbiryukova approved these changes 2024-02-16 15:49:49 +00:00
ironbee approved these changes 2024-02-16 15:56:36 +00:00
dkirillov approved these changes 2024-02-19 06:29:04 +00:00
alexvanin merged commit 563c1d9bd7 into master 2024-02-20 10:57:46 +00:00
alexvanin deleted branch fix/linter-per-pr 2024-02-20 10:57:47 +00:00
alexvanin referenced this pull request from a commit 2024-02-20 10:57:48 +00:00
[#308] Update linter versions
alexvanin referenced this pull request from a commit 2024-02-20 10:57:48 +00:00
[#308] Fix linter issues
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
achuprov
r.loginov
mbiryukova
ironbee
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#308
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:fix/linter-per-pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?