TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

[#290] Fix TestErrorTimeoutChecking test #312

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugifx/290-flaky_test_error_timeout_checing into master 2024-02-21 14:48:32 +00:00
Conversation 2 Commits 1 Files changed 2 +2 -1
dkirillov commented 2024-02-14 11:39:19 +00:00
Member
Copy link

close #290

close #290
dkirillov self-assigned this 2024-02-14 11:39:19 +00:00
dkirillov added 1 commit 2024-02-14 11:39:21 +00:00
[#290] Fix TestErrorTimeoutChecking test
Some checks failed
/ DCO (pull_request) Successful in 1m50s
Details
/ Vulncheck (pull_request) Successful in 2m18s
Details
/ Lint (pull_request) Failing after 2m46s
Details
/ Tests (1.20) (pull_request) Successful in 2m26s
Details
/ Tests (1.21) (pull_request) Successful in 1m56s
Details
/ Builds (1.20) (pull_request) Successful in 2m34s
Details
/ Builds (1.21) (pull_request) Successful in 2m26s
Details
6bbcf0f697 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-committers 2024-02-14 12:04:28 +00:00
dkirillov requested review from storage-services-developers 2024-02-14 12:04:28 +00:00
mbiryukova approved these changes 2024-02-16 15:50:24 +00:00
alexvanin force-pushed bugifx/290-flaky_test_error_timeout_checing from 6bbcf0f697 to 4eb2c7fb7d 2024-02-20 11:39:54 +00:00 Compare
alexvanin commented 2024-02-20 11:42:00 +00:00
Owner
Copy link

@dkirillov were you able to reproduce this data race? If so, I wonder how? Did you run test multiple times until it breaks or something different?

@dkirillov were you able to reproduce this data race? If so, I wonder how? Did you run test multiple times until it breaks or something different?
dkirillov commented 2024-02-20 13:50:21 +00:00
Author
Member
Copy link

Actually, I couldn't

Actually, I couldn't
alexvanin approved these changes 2024-02-21 14:48:23 +00:00
alexvanin merged commit 4eb2c7fb7d into master 2024-02-21 14:48:32 +00:00
alexvanin deleted branch bugifx/290-flaky_test_error_timeout_checing 2024-02-21 14:48:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#312
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugifx/290-flaky_test_error_timeout_checing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?