Limit the number of object to delete at one time #37

New issue

Closed

opened 2023-02-20 09:44:59 +00:00 by KirillovDenis · 1 comment

KirillovDenis commented

2023-02-20 09:44:59 +00:00

(Migrated from github.com)

According to spec we shouldn't be able to delete more than 1000 objects.
So we should support this limitation.
We can add something like this:

	if len(requested.Objects) > 1000 {
		h.logAndSendError(w, "object limit exceeded", reqInfo, errors.GetAPIError(errors.ErrBadRequest))
		return
	}

here

Also, this fix the following ceph tests:

multi_object_delete_key_limit
multi_objectv2_delete_key_limit

According to [spec](https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObjects.html) we shouldn't be able to delete more than 1000 objects. So we should support this limitation. We can add something like this: ``` if len(requested.Objects) > 1000 { h.logAndSendError(w, "object limit exceeded", reqInfo, errors.GetAPIError(errors.ErrBadRequest)) return } ``` [here](https://github.com/TrueCloudLab/frostfs-s3-gw/blob/3ab77c8990d02abf8a041a3f46abfe7a8964c21f/api/handler/delete.go#L178) Also, this fix the following ceph tests: * `multi_object_delete_key_limit` * `multi_objectv2_delete_key_limit`