TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 3 Actions Packages Releases 6 Activity

bugfix/multipart_removing #370

Merged
alexvanin merged 2 commits from dkirillov/frostfs-s3-gw:bugfix/multipart_removing into support/v0.28 2024-04-18 10:14:53 +00:00
Conversation 2 Commits 2 Files Changed 3
dkirillov commented 2024-04-17 11:34:51 +00:00
Collaborator
There is no content yet.
dkirillov self-assigned this 2024-04-17 11:34:51 +00:00
dkirillov added 2 commits 2024-04-17 11:34:54 +00:00
f26fa6c5c8 [#XX] Fix removing combined object 
Port #364

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
/ DCO (pull_request) Successful in 1m53s Details
/ Builds (1.20) (pull_request) Successful in 2m12s Details
/ Builds (1.21) (pull_request) Successful in 2m0s Details
/ Vulncheck (pull_request) Failing after 2m6s Details
/ Lint (pull_request) Successful in 4m45s Details
/ Tests (1.20) (pull_request) Successful in 2m56s Details
/ Tests (1.21) (pull_request) Successful in 2m47s Details
8fa8dd0166 [#XX] Fix multipart upload size in tree node 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed bugfix/multipart_removing from 8fa8dd0166 to 3f1ebde426 2024-04-17 11:36:01 +00:00 Compare
dkirillov requested review from storage-services-committers 2024-04-17 11:37:24 +00:00
dkirillov requested review from storage-services-developers 2024-04-17 11:37:28 +00:00
alexvanin approved these changes 2024-04-18 06:35:37 +00:00
alexvanin left a comment
Owner

Looks nice.

We should discuss what happens when we pass p.Size to objectPutAndHash function which calls frostfs.CreateObject that sets obj.SetPayloadSize(prm.PayloadSize).
This feels a bit weird when we store multipart link object. Shall we do something with it in v0.30.0 let's see.

Looks nice. We should discuss what happens when we pass `p.Size` to `objectPutAndHash` function which calls `frostfs.CreateObject` that sets `obj.SetPayloadSize(prm.PayloadSize)`. This feels a bit weird when we store multipart link object. Shall we do something with it in v0.30.0 let's see.
alexvanin added this to the v0.28.2 milestone 2024-04-18 06:41:16 +00:00
dkirillov commented 2024-04-18 08:30:19 +00:00
Poster
Collaborator

It seems storage node doesn't check payload size for client stream. For client cut the check exists but sdk forms proper size when cut is being performed.

Probably @fyrchik can clarify storage node behavior

It seems storage node doesn't check payload size for client stream. For client cut the check exists but sdk forms proper size when cut is being performed. Probably @fyrchik can clarify storage node behavior
alexvanin commented 2024-04-18 10:14:46 +00:00
Owner

Probably @fyrchik can clarify storage node behavior

As we discussed, object put streaming does not use payload size value from header at all, so it's okay to set any values as gateway does. As for client cut, SDK library sets payload size automatically, so user defined value is ignored as well.

> Probably @fyrchik can clarify storage node behavior As we discussed, object put streaming does not use payload size value from header at all, so it's okay to set any values as gateway does. As for client cut, SDK library sets payload size automatically, so user defined value is ignored as well.
alexvanin merged commit 3f1ebde426 into support/v0.28 2024-04-18 10:14:53 +00:00
alexvanin deleted branch bugfix/multipart_removing 2024-04-18 10:14:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.28.2
Assignees
Clear assignees
No Assignees
dkirillov
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#370
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:bugfix/multipart_removing"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?