bugfix/multipart_removing #370

Merged

alexvanin merged 2 commits from dkirillov/frostfs-s3-gw:bugfix/multipart_removing into support/v0.28

2024-09-04 19:51:13 +00:00

dkirillov commented

2024-04-17 11:34:51 +00:00

Member

No description provided.

dkirillov self-assigned this 2024-04-17 11:34:51 +00:00

dkirillov force-pushed bugfix/multipart_removing from 8fa8dd0166 to 3f1ebde426

2024-04-17 11:36:01 +00:00

Compare

dkirillov requested review from storage-services-committers 2024-04-17 11:37:24 +00:00

dkirillov requested review from storage-services-developers 2024-04-17 11:37:28 +00:00

alexvanin approved these changes 2024-04-18 06:35:37 +00:00

alexvanin left a comment

Owner

Looks nice.

We should discuss what happens when we pass p.Size to objectPutAndHash function which calls frostfs.CreateObject that sets obj.SetPayloadSize(prm.PayloadSize).
This feels a bit weird when we store multipart link object. Shall we do something with it in v0.30.0 let's see.

Looks nice. We should discuss what happens when we pass `p.Size` to `objectPutAndHash` function which calls `frostfs.CreateObject` that sets `obj.SetPayloadSize(prm.PayloadSize)`. This feels a bit weird when we store multipart link object. Shall we do something with it in v0.30.0 let's see.

alexvanin added this to the v0.28.2 milestone 2024-04-18 06:41:16 +00:00

dkirillov commented

2024-04-18 08:30:19 +00:00

Author

Member

It seems storage node doesn't check payload size for client stream. For client cut the check exists but sdk forms proper size when cut is being performed.

Probably @fyrchik can clarify storage node behavior

It seems storage node doesn't check payload size for client stream. For client cut the check exists but sdk forms proper size when cut is being performed. Probably @fyrchik can clarify storage node behavior

alexvanin commented

2024-04-18 10:14:46 +00:00

Owner

Probably @fyrchik can clarify storage node behavior

As we discussed, object put streaming does not use payload size value from header at all, so it's okay to set any values as gateway does. As for client cut, SDK library sets payload size automatically, so user defined value is ignored as well.

> Probably @fyrchik can clarify storage node behavior As we discussed, object put streaming does not use payload size value from header at all, so it's okay to set any values as gateway does. As for client cut, SDK library sets payload size automatically, so user defined value is ignored as well.

alexvanin merged commit 3f1ebde426 into support/v0.28

2024-04-18 10:14:53 +00:00

alexvanin deleted branch bugfix/multipart_removing

2024-04-18 10:14:53 +00:00

alexvanin referenced this pull request from a commit

2024-04-18 10:14:54 +00:00

[#370] Fix removing combined object

alexvanin referenced this pull request from a commit

2024-04-18 10:14:54 +00:00

[#370] Fix multipart upload size in tree node

dkirillov referenced this pull request

2024-04-19 14:27:16 +00:00