Investigate `unused` linter warnings #373

New Issue

Open

opened 2024-04-18 08:36:06 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-04-18 08:36:06 +00:00

Owner

It has field-writes-are-uses setting, which has a good default value (true), but misses some forgotten fields, see TrueCloudLab/frostfs-node#1100 for the full description.

metrics/billing.go:85:3                         unused  field `user` is unused
pkg/service/tree/tree_client_in_memory.go:67:2  unused  field `bkt` is unused
api/notifications/controller.go:39:3            unused  field `taskQueueConnection` is unused
cmd/s3-gw/app.go:84:3                           unused  field `wrkDone` is unused
cmd/s3-gw/service.go:16:2                       unused  field `serviceType` is unused

It has `field-writes-are-uses` setting, which has a good default value (`true`), but misses some forgotten fields, see https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1100 for the full description. ``` metrics/billing.go:85:3 unused field `user` is unused pkg/service/tree/tree_client_in_memory.go:67:2 unused field `bkt` is unused api/notifications/controller.go:39:3 unused field `taskQueueConnection` is unused cmd/s3-gw/app.go:84:3 unused field `wrkDone` is unused cmd/s3-gw/service.go:16:2 unused field `serviceType` is unused ```

👍 1