feature/increase_test_coverage #387

r.loginov · 2024-05-16T05:59:26Z

r.loginov commented

2024-05-16 05:59:26 +00:00

Coverage:
api/middleware: 69.2 % -> 95 %

auth.go: 27.9 % -> 93.0 %
metrics.go: 94.1 % -> 96.1 %
middleware: 87.5 % -> 87.5 %
policy.go: 68.5 % -> 97.1 %
reqinfo.go: 63.5 % -> 91.2 %
response.go: 78.8 % -> 91.4 %
tracing.go: 64.9 % -> 97.3 %
util.go: 87.5 % -> 100 %

Coverage: api/middleware: 69.2 % -> 95 % - auth.go: 27.9 % -> 93.0 % - metrics.go: 94.1 % -> 96.1 % - middleware: 87.5 % -> 87.5 % - policy.go: 68.5 % -> 97.1 % - reqinfo.go: 63.5 % -> 91.2 % - response.go: 78.8 % -> 91.4 % - tracing.go: 64.9 % -> 97.3 % - util.go: 87.5 % -> 100 %

r.loginov self-assigned this 2024-05-16 05:59:26 +00:00

r.loginov added 3 commits 2024-05-16 05:59:30 +00:00

c718902e2c [##] middleware: Delete unused code

Signed-off-by: Roman Loginov <r.loginov@yadro.com>

4357734719 [##] middleware: Extend test coverage

Signed-off-by: Roman Loginov <r.loginov@yadro.com>

/ DCO (pull_request) Failing after 1m33s Details

/ Vulncheck (pull_request) Successful in 1m49s Details

/ Builds (1.20) (pull_request) Successful in 2m29s Details

/ Builds (1.21) (pull_request) Successful in 1m44s Details

/ Lint (pull_request) Successful in 3m56s Details

/ Tests (1.20) (pull_request) Successful in 2m29s Details

/ Tests (1.21) (pull_request) Successful in 2m24s Details

23af453756 [##] api: Add tests for middleware

Signed-off-by: Roman Loginov <r.loginov@yadro.com>

r.loginov force-pushed feature/increase_test_coverage from 23af453756 to 02121ba548

2024-05-16 06:11:04 +00:00

Compare

r.loginov requested review from storage-services-committers 2024-05-16 06:23:57 +00:00

r.loginov requested review from storage-services-developers 2024-05-16 06:23:57 +00:00

r.loginov force-pushed feature/increase_test_coverage from 02121ba548 to a0aa6c6749

2024-05-16 10:04:22 +00:00

Compare

pogpp approved these changes 2024-05-16 13:19:06 +00:00

mbiryukova approved these changes 2024-05-17 12:02:43 +00:00

api/middleware/policy_test.go Outdated

													
				@ -83,0 +88,4 @@

						name       string

						method     string

						queryParam map[string]string

						excepted   string

mbiryukova commented

2024-05-17 10:43:29 +00:00

expected?

👍 1

r.loginov force-pushed feature/increase_test_coverage from a0aa6c6749 to a357aef3a3

2024-05-17 15:18:59 +00:00

Compare

dkirillov approved these changes 2024-05-20 13:20:57 +00:00

api/router_test.go Outdated

													
				@ -44,3 +44,3 @@

				}

				func prepareRouter(t *testing.T) *routerMock {

				func prepareRouter(t *testing.T, frostFSIDValidation bool) *routerMock {