feature/increase_test_coverage #387

Merged
alexvanin merged 4 commits from r.loginov/frostfs-s3-gw:feature/increase_test_coverage into master 2024-05-22 15:06:05 +00:00
Member

Coverage:
api/middleware: 69.2 % -> 95 %

  • auth.go: 27.9 % -> 93.0 %
  • metrics.go: 94.1 % -> 96.1 %
  • middleware: 87.5 % -> 87.5 %
  • policy.go: 68.5 % -> 97.1 %
  • reqinfo.go: 63.5 % -> 91.2 %
  • response.go: 78.8 % -> 91.4 %
  • tracing.go: 64.9 % -> 97.3 %
  • util.go: 87.5 % -> 100 %
Coverage: api/middleware: 69.2 % -> 95 % - auth.go: 27.9 % -> 93.0 % - metrics.go: 94.1 % -> 96.1 % - middleware: 87.5 % -> 87.5 % - policy.go: 68.5 % -> 97.1 % - reqinfo.go: 63.5 % -> 91.2 % - response.go: 78.8 % -> 91.4 % - tracing.go: 64.9 % -> 97.3 % - util.go: 87.5 % -> 100 %
r.loginov self-assigned this 2024-05-16 05:59:26 +00:00
r.loginov force-pushed feature/increase_test_coverage from 23af453756 to 02121ba548 2024-05-16 06:11:04 +00:00 Compare
r.loginov requested review from storage-services-committers 2024-05-16 06:23:57 +00:00
r.loginov requested review from storage-services-developers 2024-05-16 06:23:57 +00:00
r.loginov force-pushed feature/increase_test_coverage from 02121ba548 to a0aa6c6749 2024-05-16 10:04:22 +00:00 Compare
pogpp approved these changes 2024-05-16 13:19:06 +00:00
mbiryukova approved these changes 2024-05-17 12:02:43 +00:00
@ -83,0 +88,4 @@
name string
method string
queryParam map[string]string
excepted string
Member

expected?

expected?
r.loginov force-pushed feature/increase_test_coverage from a0aa6c6749 to a357aef3a3 2024-05-17 15:18:59 +00:00 Compare
dkirillov approved these changes 2024-05-20 13:20:57 +00:00
@ -44,3 +44,3 @@
}
func prepareRouter(t *testing.T) *routerMock {
func prepareRouter(t *testing.T, frostFSIDValidation bool) *routerMock {
Member

Can we make this param optional?

Can we make this param optional?
dkirillov marked this conversation as resolved
r.loginov force-pushed feature/increase_test_coverage from a357aef3a3 to 793995f78d 2024-05-20 16:20:56 +00:00 Compare
dkirillov approved these changes 2024-05-21 06:22:11 +00:00
alexvanin approved these changes 2024-05-22 15:05:57 +00:00
alexvanin merged commit 9152b084ec into master 2024-05-22 15:06:05 +00:00
alexvanin deleted branch feature/increase_test_coverage 2024-05-22 15:06:05 +00:00
alexvanin referenced this pull request from a commit 2024-05-22 15:06:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#387
No description provided.