Configure logger sampling policy #461

New issue

Closed

opened 2024-08-13 12:27:46 +00:00 by dkirillov · 0 comments

dkirillov commented

2024-08-13 12:27:46 +00:00

Member

Currently we use default sampling parameter (see zap.NewProductionConfig) that refers to

// Sampling is enabled at 100:100 by default,
// meaning that after the first 100 log entries
// with the same level and message in the same second,
// it will log every 100th entry
// with the same level and message in the same second.

It would be nice to be able to configure these parameters

Describe the solution you'd like

Add new config params to tune sampling parameters

Describe alternatives you've considered

Don't change anything

Additional context

## Is your feature request related to a problem? Please describe. Currently we use default sampling parameter (see [zap.NewProductionConfig](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/20719bd85cd8667e0377472a7c07c06094949c52/cmd/s3-gw/app_settings.go#L973)) that refers to > // Sampling is enabled at 100:100 by default, // meaning that after the first 100 log entries // with the same level and message in the same second, // it will log every 100th entry // with the same level and message in the same second. It would be nice to be able to configure these parameters ## Describe the solution you'd like Add new config params to tune sampling parameters ## Describe alternatives you've considered Don't change anything ## Additional context No