TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

feature/virtual-hosted-style #465

Merged
alexvanin merged 3 commits from feature/virtual-hosted-style into master 2024-08-23 08:35:06 +00:00
Conversation 0 Commits 3 Files changed 20 +929 -244
r.loginov commented 2024-08-19 13:38:29 +00:00
Member
Copy link

The final version of virtual-hosted-style for frostfs-s3-gw.

The final version of virtual-hosted-style for frostfs-s3-gw.
r.loginov self-assigned this 2024-08-19 13:38:29 +00:00
r.loginov added 3 commits 2024-08-19 13:38:33 +00:00 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
[#449] Add support headers for vhs and servername
All checks were successful
/ DCO (pull_request) Successful in 56s
Details
/ Vulncheck (pull_request) Successful in 1m12s
Details
/ Builds (1.21) (pull_request) Successful in 1m31s
Details
/ Builds (1.22) (pull_request) Successful in 1m15s
Details
/ Lint (pull_request) Successful in 2m21s
Details
/ Tests (1.21) (pull_request) Successful in 1m37s
Details
/ Tests (1.22) (pull_request) Successful in 1m35s
Details
71f75a8b3d 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov requested review from storage-services-committers 2024-08-19 13:44:18 +00:00
r.loginov requested review from storage-services-developers 2024-08-19 13:44:18 +00:00
dkirillov approved these changes 2024-08-20 06:54:19 +00:00
dkirillov left a comment
Member
Copy link

LGTM

LGTM
alexvanin reviewed 2024-08-21 13:55:34 +00:00
docs/configuration.md
@ -200,3 +201,4 @@
listen_domains:
- s3dev.frostfs.devenv
- s3dev.<wildcard>.frostfs.devenv
- s3dev2.frostfs.devenv
alexvanin commented 2024-08-21 13:52:46 +00:00
Owner
Copy link

@dkirillov Have you discussed putting it into vhs section?

@dkirillov Have you discussed putting it into `vhs` section?
dkirillov commented 2024-08-23 08:16:58 +00:00
Member
Copy link

We haven't discussed. I'm ok with keeping params in listen_domains

We haven't discussed. I'm ok with keeping params in `listen_domains`
docs/configuration.md Outdated
@ -724,0 +743,4 @@
| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for buckets at the application level. |
| `vhs_header` | `string` | yes | `X-Frostfs-S3-VHS` | Header for determining whether VHS is enabled for the request. |
| `servername_header` | `string` | yes | `X-Frostfs-Servername` | Header for determining servername. |
| `namespaces` | `map[string]bool` | yes | | A map in which the keys are the name of the namespace, and the values are the flag responsible for enabling VHS for the specified namespace. |
alexvanin commented 2024-08-21 13:51:42 +00:00
Owner
Copy link

I think this overrides enabled flag in vhs section, even when it is disabled. Let's mention that in description.

For example:

Overrides global 'enabled' setting even when it is disabled
I think this overrides `enabled` flag in `vhs` section, even when it is disabled. Let's mention that in description. For example: ``` Overrides global 'enabled' setting even when it is disabled ```
alexvanin marked this conversation as resolved
r.loginov force-pushed feature/virtual-hosted-style from 71f75a8b3d to 0f564880bf 2024-08-22 08:00:15 +00:00 Compare
r.loginov force-pushed feature/virtual-hosted-style from 0f564880bf to d9fbe4de84 2024-08-22 08:10:52 +00:00 Compare
alexvanin approved these changes 2024-08-23 06:39:38 +00:00
dkirillov approved these changes 2024-08-23 08:17:16 +00:00
alexvanin merged commit bf00fa6aa9 into master 2024-08-23 08:35:06 +00:00
alexvanin deleted branch feature/virtual-hosted-style 2024-08-23 08:35:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#465
No description provided.
Delete branch "feature/virtual-hosted-style"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?