bugfix/vhs #493

r.loginov · 2024-09-16T10:56:47Z

r.loginov commented

2024-09-16 10:56:47 +00:00

No description provided.

r.loginov self-assigned this 2024-09-16 10:56:47 +00:00

r.loginov added 2 commits 2024-09-16 10:56:47 +00:00

[##] Fix X-Frostfs-S3-VHS header processing a0aba8bcb1

It is assumed that the X-Frostfs-S3-VHS header
will have the value enabled/disabled instead
of true/false.

Signed-off-by: Roman Loginov <r.loginov@yadro.com>

[##] Fix of receiving VHS namespaces map

/ DCO (pull_request) Failing after 51s

Details

/ Vulncheck (pull_request) Successful in 1m13s

Details

/ Builds (pull_request) Successful in 1m25s

Details

/ Lint (pull_request) Successful in 2m23s

Details

/ Tests (pull_request) Successful in 1m26s

Details

4424aeeb71

In the process of forming a map with namespaces
for which VHS is enabled, we resolve the alias
of the namespace. The problem is that to resolve,
we need default namespace names, which in turn do
not have time to decide by this time. Therefore,
the receipt of a card with VHS namespaces must
be postponed after reading the default names for
the namespace.

Signed-off-by: Roman Loginov <r.loginov@yadro.com>

r.loginov force-pushed feature/vhs from 4424aeeb71 to 57dc2e4bbf

2024-09-16 11:20:01 +00:00

Compare

r.loginov changed title from ~~feature/vhs~~ to bugfix/vhs

2024-09-16 11:26:28 +00:00

r.loginov force-pushed feature/vhs from 57dc2e4bbf to 9a97e38ddf

2024-09-16 11:28:35 +00:00

Compare

mbiryukova approved these changes 2024-09-16 14:03:09 +00:00

Dismissed

nzinkevich approved these changes 2024-09-17 05:36:22 +00:00

Dismissed

pogpp approved these changes 2024-09-17 08:46:48 +00:00

Dismissed

alexvanin reviewed 2024-09-17 12:39:29 +00:00

cmd/s3-gw/app.go Outdated

					
				@ -300,1 +301,3 @@

					return vhsNamespaces

					s.mu.Lock()

					s.vhsNamespacesEnabled = vhsNamespaces

					s.mu.Unlock()

alexvanin commented

2024-09-17 12:39:29 +00:00

In #463 we reduced mutex usage, and here we add one more mutex call again. Let's change this a bit.

Maybe we can pass some values into prepareVHSNamespaces that has been read in update() function? Use these values, return map and set it once during mutex lock in update() function as it was before.

If I didn't understand the problem correctly, please elaborate.

In https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/463 we reduced mutex usage, and here we add one more mutex call again. Let's change this a bit. Maybe we can pass some values into `prepareVHSNamespaces` that has been read in `update()` function? Use these values, return map and set it once during mutex lock in `update()` function as it was before. If I didn't understand the problem correctly, please elaborate.

👍 1

alexvanin marked this conversation as resolved

alexvanin requested changes 2024-09-17 12:40:36 +00:00

Dismissed

alexvanin left a comment

See #493 (comment)

See https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/493#issuecomment-52210

r.loginov force-pushed feature/vhs from 9a97e38ddf to 8ca73e2079

2024-09-17 14:00:39 +00:00

Compare

r.loginov dismissed mbiryukova's review 2024-09-17 14:00:39 +00:00

Reason: