Make query tracing more detailed #498

New issue

Open

opened 2024-09-25 02:13:26 +00:00 by r.loginov · 0 comments

r.loginov commented

2024-09-25 02:13:26 +00:00

Member

At the moment, the trace in s3 gate contains span of only one type : REQUEST S3, which captures any request in frostfs-s3-gw. Having only one span does not allow you to accurately track the steps within the s3 query.

Describe the solution you'd like

It is necessary to improve the detail of tracing by adding several nested spans for various stages of execution. I suggest adding span's to operations from the main layers of the application, such as:

Request handler functions from the handler package.
Functions of the main business logic from the layer package.

You can further expand the detail, and add spans to the logic layer of working with APE, the logic layer of working with Tree Service, storage, etc. Ideally, I think it would be great to observe the main stages of its execution within the framework of one trace, as well as actions before and after the execution of the basic business logic. Suggestions in the comments are welcome.

## Is your feature request related to a problem? Please describe. At the moment, the trace in s3 gate contains span of only [one type](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/api/middleware/tracing.go#L19) : `REQUEST S3`, which captures any request in frostfs-s3-gw. Having only one span does not allow you to accurately track the steps within the s3 query. ## Describe the solution you'd like It is necessary to improve the detail of tracing by adding several nested spans for various stages of execution. I suggest adding span's to operations from the main layers of the application, such as: - Request handler functions from the handler package. - Functions of the main business logic from the layer package. You can further expand the detail, and add spans to the logic layer of working with APE, the logic layer of working with Tree Service, storage, etc. Ideally, I think it would be great to observe the main stages of its execution within the framework of one trace, as well as actions before and after the execution of the basic business logic. Suggestions in the comments are welcome.