TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 17 Packages Activity Actions

Fix of sighup traicing docs #499

Merged
alexvanin merged 1 commit from r.loginov/frostfs-s3-gw:feature/сlarification_of_tracing_documentation into master 2024-09-26 06:21:17 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
r.loginov commented 2024-09-25 11:27:24 +00:00
Member
Copy link

The tracing.enabled parameter cannot actually be called sighup updatable, because when sighup reboots, we do not add interceptors to the grpc connection.

The `tracing.enabled` parameter cannot actually be called sighup updatable, because when sighup reboots, we [do not add interceptors](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/cmd/s3-gw/app.go#L677) to the grpc connection.
r.loginov self-assigned this 2024-09-25 11:27:24 +00:00
r.loginov added 1 commit 2024-09-25 11:27:24 +00:00
[##] Fix of sighup traicing docs
Some checks failed
/ DCO (pull_request) Failing after 1m11s
Details
/ Builds (pull_request) Successful in 1m38s
Details
/ Vulncheck (pull_request) Successful in 1m49s
Details
/ Lint (pull_request) Successful in 1m59s
Details
/ Tests (pull_request) Successful in 1m36s
Details
8886a7d363 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov force-pushed feature/сlarification_of_tracing_documentation from 8886a7d363 to cd96adef36 2024-09-25 11:35:06 +00:00 Compare
r.loginov changed title from [##] Fix of sighup traicing docs to Fix of sighup traicing docs 2024-09-25 11:36:19 +00:00
r.loginov requested review from alexvanin 2024-09-25 11:39:20 +00:00
r.loginov requested review from dkirillov 2024-09-25 11:39:20 +00:00
r.loginov requested review from pogpp 2024-09-25 11:39:20 +00:00
r.loginov requested review from mbiryukova 2024-09-25 11:39:20 +00:00
r.loginov requested review from nzinkevich 2024-09-25 11:39:21 +00:00
alexvanin approved these changes 2024-09-25 14:38:21 +00:00
dkirillov approved these changes 2024-09-26 06:18:33 +00:00
alexvanin merged commit cd96adef36 into master 2024-09-26 06:21:17 +00:00
alexvanin referenced this pull request from a commit 2024-09-26 06:21:19 +00:00
[#499] Fix of sighup traicing docs
alexvanin deleted branch feature/сlarification_of_tracing_documentation 2024-09-26 06:21:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
mbiryukova
nzinkevich
alexvanin
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#499
No description provided.
Delete branch "r.loginov/frostfs-s3-gw:feature/сlarification_of_tracing_documentation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?