Add the trace id to the logs of erroneous requests at the middleware level #501
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#501
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is your feature request related to a problem? Please describe.
At the moment, with tracing enabled, there may be situations when the query log that failed will not contain the trace id.
For example, when requesting the deletion of a non-empty bucket, we will get an error and the trace id will be in the logs. But for example, when requesting to upload an object to a non-existent bucket, we will not have a trace id in the logs (this is due to the fact that an error occurs in middlware at the access rights verification stage, and the trace id is roughly added to the request logs if it has already passed middleware).
Describe the solution you'd like
I suggest adding a trace id in the log of requests that end with errors at the middleware level. Suggestions and comments are welcome.