TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

Support custom s3 credentials #515

Merged
alexvanin merged 7 commits from dkirillov/frostfs-s3-gw:poc/custom_aws_creds into master 2024-11-02 14:21:44 +00:00
Conversation 0 Commits 7 Files changed 28 +1098 -437
dkirillov commented 2024-10-11 12:44:17 +00:00
Member
Copy link

close #509

close #509
dkirillov self-assigned this 2024-10-11 12:44:17 +00:00
dkirillov added 4 commits 2024-10-11 12:44:17 +00:00 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#509] Update docs
All checks were successful
/ DCO (pull_request) Successful in 1m47s
Details
/ Vulncheck (pull_request) Successful in 1m53s
Details
/ Builds (pull_request) Successful in 1m41s
Details
/ Lint (pull_request) Successful in 3m27s
Details
/ Tests (pull_request) Successful in 1m38s
Details
6c4ace3c59 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed poc/custom_aws_creds from 6c4ace3c59 to a14ef83c7f 2024-10-11 12:45:14 +00:00 Compare
dkirillov requested review from storage-services-developers 2024-10-11 12:45:16 +00:00
dkirillov requested review from storage-services-committers 2024-10-11 12:45:20 +00:00
alexvanin reviewed 2024-10-14 08:42:26 +00:00
authmate/authmate.go Outdated
@ -188,4 +176,0 @@
prm.Owner = idOwner
prm.FriendlyName = opts.FriendlyName
cnrID, err := a.frostFS.CreateContainer(ctx, prm)
alexvanin commented 2024-10-14 08:42:26 +00:00
Owner
Copy link

issue-secret command now requires to create container upfront?

`issue-secret` command now _requires_ to create container upfront?
dkirillov commented 2024-10-14 09:08:58 +00:00
Author
Member
Copy link

Not now. It was always necessary

Not now. It was always necessary
dkirillov added 1 commit 2024-10-14 09:07:19 +00:00
[#509] Save isCustom flag into accessbox
All checks were successful
/ DCO (pull_request) Successful in 1m2s
Details
/ Vulncheck (pull_request) Successful in 1m31s
Details
/ Builds (pull_request) Successful in 1m32s
Details
/ Lint (pull_request) Successful in 2m32s
Details
/ Tests (pull_request) Successful in 1m34s
Details
523ffd9813 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
alexvanin approved these changes 2024-10-14 11:05:32 +00:00
Dismissed
dkirillov added 1 commit 2024-10-18 11:49:01 +00:00
[#509] Init resolvers before first resolving
All checks were successful
/ DCO (pull_request) Successful in 1m11s
Details
/ Builds (pull_request) Successful in 1m27s
Details
/ Vulncheck (pull_request) Successful in 1m44s
Details
/ Lint (pull_request) Successful in 2m26s
Details
/ Tests (pull_request) Successful in 1m29s
Details
41c0a328a4 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov dismissed alexvanin's review 2024-10-18 11:49:01 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov added 1 commit 2024-10-18 14:14:49 +00:00
[#509] Support fallback address when getting box
All checks were successful
/ DCO (pull_request) Successful in 1m12s
Details
/ Vulncheck (pull_request) Successful in 1m28s
Details
/ Builds (pull_request) Successful in 1m25s
Details
/ Lint (pull_request) Successful in 2m24s
Details
/ Tests (pull_request) Successful in 1m26s
Details
97fbccd1f2 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed poc/custom_aws_creds from 97fbccd1f2 to 97b9206230 2024-10-23 12:01:01 +00:00 Compare
dkirillov force-pushed poc/custom_aws_creds from 97b9206230 to 3cf27d281d 2024-10-23 12:01:44 +00:00 Compare
alexvanin approved these changes 2024-10-23 12:08:39 +00:00
alexvanin merged commit 3cf27d281d into master 2024-10-23 12:08:43 +00:00
alexvanin deleted branch poc/custom_aws_creds 2024-10-23 12:08:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#515
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:poc/custom_aws_creds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?