TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

Fix LifecycleConfiguration processing #536

New issue
Closed
opened 2024-11-01 13:22:31 +00:00 by dkirillov · 0 comments
dkirillov commented 2024-11-01 13:22:31 +00:00
Member
Copy link

Expected Behavior

Tests:

pass

Current Behavior

Tests not pass

Possible Solution

  • Support legacy Rule.Prefix field in LifecycleConfiguration.
  • Change error status from XMLMalformed to InvalidArgument when parsing expiration rules
  • Return expiration info when put/head object

Steps to Reproduce (for bugs)

  1. Run tests

Context

No

Regression

No

<!--- Provide a general summary of the issue in the Title above --> ## Expected Behavior Tests: * [test_lifecycle_get](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8200) * [test_lifecycle_get_no_id](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8211) * [test_lifecycle_set](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8190) * [test_lifecycle_id_too_long](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8729) * [test_lifecycle_same_id](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8741) * [test_lifecycle_set_invalid_date](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8792) * [test_lifecycle_expiration_days0](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8828) * [test_lifecycle_expiration_header_put](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8879) * [test_lifecycle_expiration_header_head](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_s3.py#L8891) pass ## Current Behavior Tests not pass ## Possible Solution * Support legacy `Rule.Prefix` field in LifecycleConfiguration. * Change error status from `XMLMalformed` to `InvalidArgument` when parsing expiration rules * Return expiration info when put/head object ## Steps to Reproduce (for bugs) <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. --> 1. Run tests ## Context No ## Regression No
dkirillov added the
bug
 label 2024-11-01 13:22:31 +00:00
mbiryukova self-assigned this 2024-11-06 09:46:32 +00:00
alexvanin added this to the v0.31.0 milestone 2024-11-12 12:50:58 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.30
support/v0.29
support/v0.28
support/v0.27
v0.31.0
v0.31.0-rc.6
v0.31.0-rc.5
v0.31.0-rc.4
v0.30.8
v0.31.0-rc.3
v0.30.7
v0.31.0-rc.2
v0.31.0-rc.1
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.30.0-rc.5
v0.29.2
v0.30.0-rc.4
v0.30.0-rc.3
v0.30.0-rc.2
v0.29.1
v0.30.0-rc.1
v0.29.0
v0.28.2
v0.29.0-rc.11
v0.29.0-rc.10
v0.29.0-rc.9
v0.29.0-rc.8
v0.29.0-rc.7
v0.29.0-rc.6
v0.29.0-rc.5
v0.29.0-rc.4
v0.29.0-rc.3
v0.29.0-rc.2
v0.29.0-rc.1
v0.28.1
v0.28.0
v0.28.0-rc.1
v0.27.0
v0.27.0-rc.2
v0.27.0-rc.1
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#536
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?