TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

Fix checking Content-MD5 header #540

New issue
Closed
opened 2024-11-01 14:02:40 +00:00 by dkirillov · 0 comments
dkirillov commented 2024-11-01 14:02:40 +00:00
Member
Copy link

Expected Behavior

Tests pass:

Current Behavior

Test fail

Possible Solution

  • Fix error code from InvalidDigest to BadDigest
  • Check empty Content-MD5

Steps to Reproduce (for bugs)

  1. Run tests

Context

Regression

Probably yes

Your Environment

  • Version used: v0.31.0-rc.4
<!--- Provide a general summary of the issue in the Title above --> ## Expected Behavior <!--- If you're describing a bug, tell us what should happen --> <!--- If you're suggesting a change/improvement, tell us how it should work --> Tests pass: * [test_object_create_bad_md5_bad](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_headers.py#L164) * [test_object_create_bad_md5_empty](https://git.frostfs.info/TrueCloudLab/s3-tests/src/commit/d245097771698774d36a0283e9ef69bf67f3ba76/s3tests_boto3/functional/test_headers.py#L171) ## Current Behavior <!--- If describing a bug, tell us what happens instead of the expected behavior --> <!--- If suggesting a change/improvement, explain the difference from current behavior --> Test fail ## Possible Solution <!--- Not obligatory --> <!--- If no reason/fix/additions for the bug can be suggested, --> <!--- uncomment the following phrase: --> <!--- No fix can be suggested by a QA engineer. Further solutions shall be up to developers. --> * Fix error code from `InvalidDigest` to `BadDigest` * Check empty Content-MD5 ## Steps to Reproduce (for bugs) <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. --> 1. Run tests ## Context <!--- How has this issue affected you? What are you trying to accomplish? --> <!--- Providing context helps us come up with a solution that is most useful in the real world --> ## Regression <!-- Is this issue a regression? (Yes / No) --> <!-- If Yes, optionally please include version or commit id or PR# that caused this regression, if you have these details. --> Probably yes ## Your Environment <!--- Include as many relevant details about the environment you experienced the bug in --> * Version used: v0.31.0-rc.4
dkirillov added the
bug
 label 2024-11-01 14:02:40 +00:00
pogpp self-assigned this 2024-11-06 11:43:39 +00:00
alexvanin added this to the v0.31.0 milestone 2024-11-20 12:16:30 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.31
support/v0.30
support/v0.29
support/v0.28
support/v0.27
v0.33.0-pre
v0.32.0
v0.31.3
v0.31.2
v0.30.9
v0.31.1
v0.31.0
v0.31.0-rc.6
v0.31.0-rc.5
v0.31.0-rc.4
v0.30.8
v0.31.0-rc.3
v0.30.7
v0.31.0-rc.2
v0.31.0-rc.1
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.30.0-rc.5
v0.29.2
v0.30.0-rc.4
v0.30.0-rc.3
v0.30.0-rc.2
v0.29.1
v0.30.0-rc.1
v0.29.0
v0.28.2
v0.29.0-rc.11
v0.29.0-rc.10
v0.29.0-rc.9
v0.29.0-rc.8
v0.29.0-rc.7
v0.29.0-rc.6
v0.29.0-rc.5
v0.29.0-rc.4
v0.29.0-rc.3
v0.29.0-rc.2
v0.29.0-rc.1
v0.28.1
v0.28.0
v0.28.0-rc.1
v0.27.0
v0.27.0-rc.2
v0.27.0-rc.1
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
pogpp
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#540
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?