TrueCloudLab/frostfs-s3-gw

Fork 20

Run builds on push to master branch #550

New issue

Closed

opened 2024-11-15 09:53:25 +00:00 by alexvanin · 5 comments

alexvanin commented

2024-11-15 09:53:25 +00:00

Owner

This repo uses "rebase and ff" strategy to merge pull requests. Two PRs may break master branch if one changes function signature, another use it, and both are merged at one time. All checks will be green, but master branch is going to be broken.

Describe the solution you'd like

The fastest way to find broken master is to build nightly build. Until then we can trigger build job on every push to master branch. And we can notice red cross on a latest commit message.

It seems to me as common practice, see neo-go workflow for example.

Let's discuss it and update trigger for build job it this proposal makes sense.

/cc @potyarkin, @realloc

## Is your feature request related to a problem? Please describe. This repo uses "rebase and ff" strategy to merge pull requests. Two PRs may break master branch if one changes function signature, another use it, and both are merged at one time. All checks will be green, but master branch is going to be broken. ## Describe the solution you'd like The fastest way to find broken master is to build nightly build. Until then we can trigger build job on every push to master branch. And we can notice red cross on a latest commit message. It seems to me as common practice, see [neo-go](https://github.com/nspcc-dev/neo-go/blob/5707bdd1d1d91bd69e34e68fdb857a02ce6d8e6c/.github/workflows/build.yml#L11-L14) workflow for example. Let's discuss it and update trigger for build job it this proposal makes sense. /cc @potyarkin, @realloc

alexvanin added the

discussion

label 2024-11-15 09:53:48 +00:00

alexvanin commented

2024-11-15 09:55:37 +00:00

Author

Owner

I am against "ff-only" merge strategy, because master break happens quite rarely, and ff-only is going to slow down merge process in my opinion.

potyarkin commented

2024-11-15 10:02:18 +00:00

Member

~~I was about to suggest "ff-only" when I saw your updated comment~~

I see no downsides in adding CI runs on push to master and on schedule. Would you like this behavior in frostfs-s3-gw only or across all of services team repos?

~~I was about to suggest "ff-only" when I saw your updated comment~~ I see no downsides in adding CI runs [on push](https://forgejo.org/docs/latest/user/actions/#onpush) to master and [on schedule](https://forgejo.org/docs/latest/user/actions/#onschedule). Would you like this behavior in frostfs-s3-gw only or across all of services team repos?

potyarkin self-assigned this 2024-11-15 10:07:21 +00:00

alexvanin commented

2024-11-15 10:13:53 +00:00

Author

Owner

Would you like this behavior in frostfs-s3-gw only or across all of services team repos?

Let's do this across s3 and http gateways. Not sure we need schedule runs, on push should be enough.

> Would you like this behavior in frostfs-s3-gw only or across all of services team repos? Let's do this across s3 and http gateways. Not sure we need schedule runs, on push should be enough.

👍 1

potyarkin referenced this issue from a commit

2024-11-15 11:33:25 +00:00

[#165] Execute CI on push to master

potyarkin referenced this issue from TrueCloudLab/frostfs-http-gw

2024-11-15 11:35:40 +00:00

Execute CI on push to master #165

potyarkin referenced this issue

2024-11-15 11:35:47 +00:00

Execute CI on push to master #552

potyarkin referenced this issue from a commit

2024-11-15 11:41:14 +00:00

[#165] Execute CI on push to master

potyarkin commented

2024-11-15 11:55:15 +00:00

Member

I've added on.push to all workflows, except for DCO checker: there is no PR base ref during push, and adding custom handling for push events seems overkill since we do not allow direct pushes to master anyways. Merge conflicts can not happen in commit messages 😄

See:

I've added `on.push` to all workflows, except for DCO checker: there is no PR base ref during push, and adding custom handling for push events seems overkill since we do not allow direct pushes to master anyways. Merge conflicts can not happen in commit messages 😄 See: - https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/552 - https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/pulls/165

alexvanin referenced this issue from a commit

2024-11-18 11:41:34 +00:00

[#550] Execute CI on push to master

alexvanin commented

2024-11-18 11:41:56 +00:00

Author

Owner

@potyarkin Thanks! Closed.

alexvanin closed this issue

2024-11-18 11:42:04 +00:00