TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 28 Pull requests 9 Projects Releases 26 Packages 1 Activity Actions

WIP: Fix possible memory leak and deadlock #617

Draft
alexvanin wants to merge 2 commits from alexvanin/frostfs-s3-gw:fix/support-deadlock-leak into support/v0.32
pull from: alexvanin/frostfs-s3-gw:fix/support-deadlock-leak
merge into: TrueCloudLab:support/v0.32
Conversation 0 Commits 2 Files changed 4 +59 -47
alexvanin commented 2025-01-30 13:11:44 +00:00
Owner
Copy link

Fixes:

Fixes: - possible memory leak (https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/327, https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/324) - possible deadlock (https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/326)
alexvanin added 2 commits 2025-01-30 13:11:45 +00:00 
Contains fixes:
- memory leak in gRPC client,
- panic and deadlock in tree pool.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
Release v0.32.4
Some checks failed
/ Vulncheck (pull_request) Successful in 1m19s
Details
/ DCO (pull_request) Failing after 1m39s
Details
/ Builds (pull_request) Successful in 1m44s
Details
/ OCI image (pull_request) Successful in 3m36s
Details
/ Lint (pull_request) Successful in 3m51s
Details
/ Tests (pull_request) Successful in 1m41s
Details
156bf68ea4 
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin force-pushed fix/support-deadlock-leak from 156bf68ea4 to ee9c9a98e9 2025-01-30 13:13:05 +00:00 Compare
alexvanin force-pushed fix/support-deadlock-leak from ee9c9a98e9 to e8b5a53493 2025-01-30 13:20:08 +00:00 Compare
alexvanin added this to the v0.32.4 milestone 2025-01-30 13:23:56 +00:00
All checks were successful
/ DCO (pull_request) Successful in 48s
Details
/ Builds (pull_request) Successful in 1m24s
Details
/ Vulncheck (pull_request) Successful in 1m44s
Details
/ OCI image (pull_request) Successful in 3m9s
Details
/ Lint (pull_request) Successful in 2m35s
Details
/ Tests (pull_request) Successful in 1m8s
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/support-deadlock-leak:alexvanin-fix/support-deadlock-leak
git checkout alexvanin-fix/support-deadlock-leak
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.4
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#617
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:fix/support-deadlock-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?