TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 26 Pull requests 10 Projects Releases 34 Packages 1 Activity Actions

Update SDK Go to prevent socket starvation #654

Open
alexvanin wants to merge 2 commits from alexvanin/frostfs-s3-gw:fix/socket-starvation into support/v0.32
pull from: alexvanin/frostfs-s3-gw:fix/socket-starvation
merge into: TrueCloudLab:support/v0.32
Conversation 3 Commits 2 Files changed 9 +38 -11
alexvanin commented 2025-03-05 15:47:13 +00:00
Owner
Copy link

See more details in TrueCloudLab/frostfs-sdk-go#339

See more details in https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/339
alexvanin added 2 commits 2025-03-05 15:47:13 +00:00 
Circuit breaker prevents from port starving when some
storage nodes are up but unsynced. See more details in:

TrueCloudLab/frostfs-sdk-go#339
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
Release v0.32.12
Some checks failed
/ Vulncheck (pull_request) Has been cancelled
Details
/ Lint (pull_request) Has been cancelled
Details
/ Tests (pull_request) Has been cancelled
Details
/ OCI image (pull_request) Has been cancelled
Details
/ DCO (pull_request) Has been cancelled
Details
/ Builds (pull_request) Has been cancelled
Details
6a0bb6c484 
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin force-pushed fix/socket-starvation from 6a0bb6c484 to 89d3a258a4 2025-03-05 15:48:21 +00:00 Compare
alexvanin added this to the v0.32.12 milestone 2025-03-05 15:56:50 +00:00
alexvanin force-pushed fix/socket-starvation from 89d3a258a4 to 0de8b73dc3 2025-03-05 15:57:35 +00:00 Compare
alexvanin changed title from WIP: Update SDK Go to prevent socket starvation to Update SDK Go to prevent socket starvation 2025-03-05 16:02:15 +00:00
requested reviews from storage-services-developers, storage-services-committers 2025-03-05 16:02:15 +00:00
dkirillov reviewed 2025-03-06 06:22:00 +00:00
CHANGELOG.md Outdated
@ -465,3 +470,3 @@
[0.32.11]: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/compare/v0.32.10...v0.32.11
[Unreleased]: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/compare/v0.32.11...master
[0.32.11]: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/compare/v0.32.11...v0.32.12
dkirillov commented 2025-03-06 06:22:00 +00:00
Member
Copy link

[0.32.11] -> [0.32.12]

`[0.32.11]` -> `[0.32.12]`
👍 1
alexvanin commented 2025-03-06 07:52:31 +00:00
Author
Owner
Copy link

Fixed.

Fixed.
dkirillov reviewed 2025-03-06 06:24:09 +00:00
cmd/s3-gw/app_settings.go
@ -129,0 +130,4 @@
cfgRebalanceInterval = "rebalance_interval"
cfgPoolErrorThreshold = "pool_error_threshold"
cfgPoolCbThreshold = "pool_cb_threshold"
cfgPoolCbBreakDuration = "pool_cb_break_duration"
dkirillov commented 2025-03-06 06:24:09 +00:00
Member
Copy link

Maybe just pool_cb_timeout?

Maybe just `pool_cb_timeout`?
alexvanin commented 2025-03-06 07:45:59 +00:00
Author
Owner
Copy link

I think it's better to have the same name with SDK parameter to avoid possible confusions.

As for me "timeout" is more about the process that didn't finish in time (out of time, timeout). This is not what happening in circuit breaker. So I decided to use something different.

I think it's better to have the same name with SDK parameter to avoid possible confusions. As for me "timeout" is more about the process that didn't finish in time (out of time, timeout). This is not what happening in circuit breaker. So I decided to use something different.
mbiryukova commented 2025-03-06 09:05:34 +00:00
Member
Copy link

As I understand, pool prefix is used for object pool settings, maybe it's better to use tree?

As I understand, `pool` prefix is used for object pool settings, maybe it's better to use `tree`?
alexvanin was assigned by dkirillov 2025-03-06 06:24:20 +00:00
alexvanin force-pushed fix/socket-starvation from 0de8b73dc3 to 3ed18140f3 2025-03-06 07:48:17 +00:00 Compare
All checks were successful
/ DCO (pull_request) Successful in 43s
Details
/ Vulncheck (pull_request) Successful in 1m39s
Details
/ Builds (pull_request) Successful in 1m55s
Details
/ OCI image (pull_request) Successful in 2m15s
Details
/ Lint (pull_request) Successful in 3m22s
Details
/ Tests (pull_request) Successful in 1m31s
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/socket-starvation:alexvanin-fix/socket-starvation
git checkout alexvanin-fix/socket-starvation
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.12
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
alexvanin
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#654
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:fix/socket-starvation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?