Deleting objects/bucket when object is missing or removed in metabase #78

New Issue

Closed

opened 2023-04-04 12:28:58 +00:00 by alexvanin · 0 comments

alexvanin commented

2023-04-04 12:28:58 +00:00

Owner

In #71 we fixed a case when tree service or fstree/blobovniza are missing in the storage.

However there are still cases when object is not accessible from the metabase:

object is considered as non-existing,
object is already removed by node.

We can use @dkirillov proposal:

Actually, to delete bucket when we not found object in object service, we have to update listing (to skip objects that exist only in tree service) or delete object from tree service.

Originally posted by @dkirillov in #71 (comment)

Deleting values from tree services when object not found seems dangerous for me, because this error might be unrelated to actual object placement. However object is already removed gives us some context and we can consider removing data from the tree service in this case.

/cc @dkirillov, @ironbee, @realloc

In #71 we fixed a case when tree service or fstree/blobovniza are missing in the storage. However there are still cases when object is not accessible from the metabase: - object is considered as non-existing, - object is already removed by node. We can use @dkirillov proposal: > Actually, to delete bucket when we not found object in object service, we have to update [listing](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/01afa1cae4253d7dd375f1cf52d1f65e66d5ca06/api/layer/object.go#L591) (to skip objects that exist only in tree service) or delete object from tree service. > > _Originally posted by @dkirillov in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/71#issuecomment-4486_ Deleting values from tree services when `object not found` seems dangerous for me, because this error might be unrelated to actual object placement. **However** `object is already removed` gives us some context and we can consider removing data from the tree service in this case. /cc @dkirillov, @ironbee, @realloc