Add succesfull requests metrics #85

New issue

Closed

opened 2023-04-14 13:20:18 +00:00 by alexvanin · 2 comments

alexvanin commented

2023-04-14 13:20:18 +00:00

Owner

We have metrics for total number of requests. For monitoring purposes it would be nice to distinguish number of successful metrics to estimate gateway healthiness based on request success rate.

Describe the solution you'd like

Add new metric that return number of successful requests. It should count requests with all return codes except 5** codes (please verify it @a.bogatyrev).

Describe alternatives you've considered

Add new metrics that return only failed requests.

## Is your feature request related to a problem? Please describe. We have metrics for total number of requests. For monitoring purposes it would be nice to distinguish number of successful metrics to estimate gateway healthiness based on request success rate. ## Describe the solution you'd like Add new metric that return number of successful requests. It should count requests with all return codes except 5** codes (please verify it @a.bogatyrev). ## Describe alternatives you've considered Add new metrics that return only failed requests.

👍 1

alexvanin added this to the v0.27.0 milestone 2023-04-14 13:20:18 +00:00

dkirillov was assigned by alexvanin

2023-04-14 13:20:18 +00:00

dkirillov commented

2023-04-17 11:02:54 +00:00

Member

Describe alternatives you've considered

Add new metrics that return only failed requests.

Actually, we already have such metric frostfs_s3_errors_total. So we can move this issue to v0.28.0 and discuss it a little bit later

> ### Describe alternatives you've considered > Add new metrics that return only failed requests. Actually, we already have such metric `frostfs_s3_errors_total`. So we can move this issue to v0.28.0 and discuss it a little bit later

dkirillov modified the milestone from v0.27.0 to v0.28.0

2023-04-17 11:03:00 +00:00

alexvanin modified the milestone from v0.28.0 to v0.29.0

2023-09-08 10:31:01 +00:00

alexvanin modified the milestone from v0.29.0 to v0.30.0

2024-05-27 11:07:25 +00:00

alexvanin removed this from the v0.30.0 milestone 2024-05-27 11:07:34 +00:00

alexvanin commented

2024-10-08 08:53:12 +00:00

Author

Owner

As for v0.30 release, there are:

frostfs_s3_gw_statistic_requests_total metric that counts all requests
frostfs_s3_gw_statistic_errors_total metric that counts all codes except 2** codes

This should be sufficient to calculate all successful requests by subtracting values of these metrics.

As for v0.30 release, there are: - `frostfs_s3_gw_statistic_requests_total` metric that counts all requests - `frostfs_s3_gw_statistic_errors_total` metric that counts all codes except 2** codes This should be sufficient to calculate all successful requests by subtracting values of these metrics.

alexvanin closed this issue

2024-10-08 08:53:13 +00:00