Denis Kirillov
465eaa816a
All checks were successful
/ DCO (pull_request) Successful in 2m15s
/ Vulncheck (pull_request) Successful in 2m55s
/ Builds (1.20) (pull_request) Successful in 3m46s
/ Builds (1.21) (pull_request) Successful in 3m48s
/ Lint (pull_request) Successful in 5m26s
/ Tests (1.20) (pull_request) Successful in 3m34s
/ Tests (1.21) (pull_request) Successful in 3m18s
Always consider buckets as APE compatible Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
313 lines
9.6 KiB
Go
313 lines
9.6 KiB
Go
package handler
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"regexp"
|
|
"time"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/auth"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/data"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/errors"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/layer"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/middleware"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-s3-gw/internal/logs"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
type copyObjectArgs struct {
|
|
Conditional *conditionalArgs
|
|
MetadataDirective string
|
|
TaggingDirective string
|
|
}
|
|
|
|
const (
|
|
replaceDirective = "REPLACE"
|
|
copyDirective = "COPY"
|
|
)
|
|
|
|
var copySourceMatcher = auth.NewRegexpMatcher(regexp.MustCompile(`^/?(?P<bucket_name>[a-z0-9.\-]{3,63})/(?P<object_name>.+)$`))
|
|
|
|
// path2BucketObject returns a bucket and an object.
|
|
func path2BucketObject(path string) (string, string, error) {
|
|
matches := copySourceMatcher.GetSubmatches(path)
|
|
if len(matches) != 2 {
|
|
return "", "", errors.GetAPIError(errors.ErrInvalidRequest)
|
|
}
|
|
|
|
return matches["bucket_name"], matches["object_name"], nil
|
|
}
|
|
|
|
func (h *handler) CopyObjectHandler(w http.ResponseWriter, r *http.Request) {
|
|
var (
|
|
err error
|
|
versionID string
|
|
metadata map[string]string
|
|
tagSet map[string]string
|
|
|
|
ctx = r.Context()
|
|
reqInfo = middleware.GetReqInfo(ctx)
|
|
|
|
cannedACLStatus = aclHeadersStatus(r)
|
|
)
|
|
|
|
src := r.Header.Get(api.AmzCopySource)
|
|
// Check https://docs.aws.amazon.com/AmazonS3/latest/dev/ObjectVersioning.html
|
|
// Regardless of whether you have enabled versioning, each object in your bucket
|
|
// has a version ID. If you have not enabled versioning, Amazon S3 sets the value
|
|
// of the version ID to null. If you have enabled versioning, Amazon S3 assigns a
|
|
// unique version ID value for the object.
|
|
if u, err := url.Parse(src); err == nil {
|
|
versionID = u.Query().Get(api.QueryVersionID)
|
|
src = u.Path
|
|
}
|
|
|
|
srcBucket, srcObject, err := path2BucketObject(src)
|
|
if err != nil {
|
|
h.logAndSendError(w, "invalid source copy", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
srcObjPrm := &layer.HeadObjectParams{
|
|
Object: srcObject,
|
|
VersionID: versionID,
|
|
}
|
|
|
|
if srcObjPrm.BktInfo, err = h.getBucketAndCheckOwner(r, srcBucket, api.AmzSourceExpectedBucketOwner); err != nil {
|
|
h.logAndSendError(w, "couldn't get source bucket", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
dstBktInfo, err := h.getBucketAndCheckOwner(r, reqInfo.BucketName)
|
|
if err != nil {
|
|
h.logAndSendError(w, "couldn't get target bucket", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
settings, err := h.obj.GetBucketSettings(ctx, dstBktInfo)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not get bucket settings", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
if cannedACLStatus == aclStatusYes {
|
|
h.logAndSendError(w, "acl not supported for this bucket", reqInfo, errors.GetAPIError(errors.ErrAccessControlListNotSupported))
|
|
return
|
|
}
|
|
|
|
extendedSrcObjInfo, err := h.obj.GetExtendedObjectInfo(ctx, srcObjPrm)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not find object", reqInfo, err)
|
|
return
|
|
}
|
|
srcObjInfo := extendedSrcObjInfo.ObjectInfo
|
|
|
|
srcEncryptionParams, err := formCopySourceEncryptionParams(r)
|
|
if err != nil {
|
|
h.logAndSendError(w, "invalid sse headers", reqInfo, err)
|
|
return
|
|
}
|
|
dstEncryptionParams, err := formEncryptionParams(r)
|
|
if err != nil {
|
|
h.logAndSendError(w, "invalid sse headers", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
if err = srcEncryptionParams.MatchObjectEncryption(layer.FormEncryptionInfo(srcObjInfo.Headers)); err != nil {
|
|
if errors.IsS3Error(err, errors.ErrInvalidEncryptionParameters) || errors.IsS3Error(err, errors.ErrSSEEncryptedObject) ||
|
|
errors.IsS3Error(err, errors.ErrInvalidSSECustomerParameters) {
|
|
h.logAndSendError(w, "encryption doesn't match object", reqInfo, err, zap.Error(err))
|
|
return
|
|
}
|
|
h.logAndSendError(w, "encryption doesn't match object", reqInfo, errors.GetAPIError(errors.ErrBadRequest), zap.Error(err))
|
|
return
|
|
}
|
|
|
|
var dstSize uint64
|
|
srcSize, err := layer.GetObjectSize(srcObjInfo)
|
|
if err != nil {
|
|
h.logAndSendError(w, "failed to get source object size", reqInfo, err)
|
|
return
|
|
} else if srcSize > layer.UploadMaxSize { // https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
|
|
h.logAndSendError(w, "too bid object to copy with single copy operation, use multipart upload copy instead", reqInfo, errors.GetAPIError(errors.ErrInvalidRequestLargeCopy))
|
|
return
|
|
}
|
|
dstSize = srcSize
|
|
|
|
args, err := parseCopyObjectArgs(r.Header)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not parse request params", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
if isCopyingToItselfForbidden(reqInfo, srcBucket, srcObject, settings, args) {
|
|
h.logAndSendError(w, "copying to itself without changing anything", reqInfo, errors.GetAPIError(errors.ErrInvalidCopyDest))
|
|
return
|
|
}
|
|
|
|
if args.MetadataDirective == replaceDirective {
|
|
metadata = parseMetadata(r)
|
|
}
|
|
|
|
if args.TaggingDirective == replaceDirective {
|
|
tagSet, err = parseTaggingHeader(r.Header)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not parse tagging header", reqInfo, err)
|
|
return
|
|
}
|
|
} else {
|
|
tagPrm := &data.GetObjectTaggingParams{
|
|
ObjectVersion: &data.ObjectVersion{
|
|
BktInfo: srcObjPrm.BktInfo,
|
|
ObjectName: srcObject,
|
|
VersionID: srcObjInfo.VersionID(),
|
|
},
|
|
NodeVersion: extendedSrcObjInfo.NodeVersion,
|
|
}
|
|
|
|
_, tagSet, err = h.obj.GetObjectTagging(ctx, tagPrm)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not get object tagging", reqInfo, err)
|
|
return
|
|
}
|
|
}
|
|
|
|
if err = checkPreconditions(srcObjInfo, args.Conditional, h.cfg.MD5Enabled()); err != nil {
|
|
h.logAndSendError(w, "precondition failed", reqInfo, errors.GetAPIError(errors.ErrPreconditionFailed))
|
|
return
|
|
}
|
|
|
|
if metadata == nil {
|
|
if len(srcObjInfo.ContentType) > 0 {
|
|
srcObjInfo.Headers[api.ContentType] = srcObjInfo.ContentType
|
|
}
|
|
metadata = makeCopyMap(srcObjInfo.Headers)
|
|
filterMetadataMap(metadata)
|
|
} else if contentType := r.Header.Get(api.ContentType); len(contentType) > 0 {
|
|
metadata[api.ContentType] = contentType
|
|
}
|
|
|
|
params := &layer.CopyObjectParams{
|
|
SrcVersioned: srcObjPrm.Versioned(),
|
|
SrcObject: srcObjInfo,
|
|
ScrBktInfo: srcObjPrm.BktInfo,
|
|
DstBktInfo: dstBktInfo,
|
|
DstObject: reqInfo.ObjectName,
|
|
DstSize: dstSize,
|
|
Header: metadata,
|
|
SrcEncryption: srcEncryptionParams,
|
|
DstEncryption: dstEncryptionParams,
|
|
}
|
|
|
|
params.CopiesNumbers, err = h.pickCopiesNumbers(metadata, reqInfo.Namespace, dstBktInfo.LocationConstraint)
|
|
if err != nil {
|
|
h.logAndSendError(w, "invalid copies number", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
params.Lock, err = formObjectLock(ctx, dstBktInfo, settings.LockConfiguration, r.Header)
|
|
if err != nil {
|
|
h.logAndSendError(w, "could not form object lock", reqInfo, err)
|
|
return
|
|
}
|
|
|
|
additional := []zap.Field{zap.String("src_bucket_name", srcBucket), zap.String("src_object_name", srcObject)}
|
|
extendedDstObjInfo, err := h.obj.CopyObject(ctx, params)
|
|
if err != nil {
|
|
h.logAndSendError(w, "couldn't copy object", reqInfo, err, additional...)
|
|
return
|
|
}
|
|
dstObjInfo := extendedDstObjInfo.ObjectInfo
|
|
|
|
if err = middleware.EncodeToResponse(w, &CopyObjectResponse{
|
|
LastModified: dstObjInfo.Created.UTC().Format(time.RFC3339),
|
|
ETag: data.Quote(dstObjInfo.ETag(h.cfg.MD5Enabled())),
|
|
}); err != nil {
|
|
h.logAndSendError(w, "something went wrong", reqInfo, err, additional...)
|
|
return
|
|
}
|
|
|
|
if tagSet != nil {
|
|
tagPrm := &data.PutObjectTaggingParams{
|
|
ObjectVersion: &data.ObjectVersion{
|
|
BktInfo: dstBktInfo,
|
|
ObjectName: reqInfo.ObjectName,
|
|
VersionID: dstObjInfo.VersionID(),
|
|
},
|
|
TagSet: tagSet,
|
|
NodeVersion: extendedDstObjInfo.NodeVersion,
|
|
}
|
|
if err = h.obj.PutObjectTagging(ctx, tagPrm); err != nil {
|
|
h.logAndSendError(w, "could not upload object tagging", reqInfo, err)
|
|
return
|
|
}
|
|
}
|
|
|
|
h.reqLogger(ctx).Info(logs.ObjectIsCopied, zap.Stringer("object_id", dstObjInfo.ID))
|
|
|
|
if dstEncryptionParams.Enabled() {
|
|
addSSECHeaders(w.Header(), r.Header)
|
|
}
|
|
}
|
|
|
|
func makeCopyMap(headers map[string]string) map[string]string {
|
|
res := make(map[string]string, len(headers))
|
|
for key, val := range headers {
|
|
res[key] = val
|
|
}
|
|
return res
|
|
}
|
|
|
|
func filterMetadataMap(metadata map[string]string) {
|
|
delete(metadata, layer.MultipartObjectSize) // object payload will be real one rather than list of compound parts
|
|
for key := range layer.EncryptionMetadata {
|
|
delete(metadata, key)
|
|
}
|
|
}
|
|
|
|
func isCopyingToItselfForbidden(reqInfo *middleware.ReqInfo, srcBucket string, srcObject string, settings *data.BucketSettings, args *copyObjectArgs) bool {
|
|
if reqInfo.BucketName != srcBucket || reqInfo.ObjectName != srcObject {
|
|
return false
|
|
}
|
|
|
|
if !settings.Unversioned() {
|
|
return false
|
|
}
|
|
|
|
return args.MetadataDirective != replaceDirective
|
|
}
|
|
|
|
func parseCopyObjectArgs(headers http.Header) (*copyObjectArgs, error) {
|
|
var err error
|
|
args := &conditionalArgs{
|
|
IfMatch: data.UnQuote(headers.Get(api.AmzCopyIfMatch)),
|
|
IfNoneMatch: data.UnQuote(headers.Get(api.AmzCopyIfNoneMatch)),
|
|
}
|
|
|
|
if args.IfModifiedSince, err = parseHTTPTime(headers.Get(api.AmzCopyIfModifiedSince)); err != nil {
|
|
return nil, err
|
|
}
|
|
if args.IfUnmodifiedSince, err = parseHTTPTime(headers.Get(api.AmzCopyIfUnmodifiedSince)); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
copyArgs := ©ObjectArgs{Conditional: args}
|
|
|
|
copyArgs.MetadataDirective = headers.Get(api.AmzMetadataDirective)
|
|
if !isValidDirective(copyArgs.MetadataDirective) {
|
|
return nil, errors.GetAPIError(errors.ErrInvalidMetadataDirective)
|
|
}
|
|
|
|
copyArgs.TaggingDirective = headers.Get(api.AmzTaggingDirective)
|
|
if !isValidDirective(copyArgs.TaggingDirective) {
|
|
return nil, errors.GetAPIError(errors.ErrInvalidTaggingDirective)
|
|
}
|
|
|
|
return copyArgs, nil
|
|
}
|
|
|
|
func isValidDirective(directive string) bool {
|
|
return len(directive) == 0 ||
|
|
directive == replaceDirective || directive == copyDirective
|
|
}
|