Do not go back in time in case of full neo-go reconnections #10

New issue

Closed

opened 2024-07-22 12:23:28 +00:00 by alexvanin · 2 comments

alexvanin commented

2024-07-22 12:23:28 +00:00

Owner

Originally posted by @alexvanin in /TrueCloudLab/frostfs-s3-lifecycler/pulls/9#issuecomment-44102

We want to avoid a case when listener reconnects to a node living in the past. We need to subscribe for new blocks and save latest block number and then use it during initialization of new connection. _Originally posted by @alexvanin in /TrueCloudLab/frostfs-s3-lifecycler/pulls/9#issuecomment-44102_

dkirillov commented

2024-07-23 06:15:20 +00:00

Member

It's already done

 	latestBlock := l.blockNumber.Load()
 	if currentBlock > latestBlock {
 		latestBlock = currentBlock
 	}

if I understood you correctly

It's already done https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler/src/commit/84ed2f55e3ad5726ea5b8b0da61999c6118d8ed0/internal/notificator/listener.go#L105-L108 if I understood you correctly

alexvanin commented

2024-07-23 08:58:00 +00:00

Author

Owner

Missed that, indeed. Closed.